doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](merge-on-write) fix cu compaction correctness check

Open liaoxin01 opened this issue 2 years ago • 7 comments

Proposed changes

Issue Number: close #xxx

Problem summary

During concurrent import, the same row location may be marked delete multiple times by different versions of rowset. Duplicate row location need to be removed.

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

liaoxin01 avatar Mar 02 '23 09:03 liaoxin01

run buildall

liaoxin01 avatar Mar 02 '23 09:03 liaoxin01

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 09:03 github-actions[bot]

TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.29 seconds stream load tsv: 477 seconds loaded 74807831229 Bytes, about 149 MB/s stream load json: 43 seconds loaded 2358488459 Bytes, about 52 MB/s stream load orc: 75 seconds loaded 1101869774 Bytes, about 14 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230305033952_clickbench_pr_108602.html

hello-stephen avatar Mar 02 '23 12:03 hello-stephen

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Mar 02 '23 12:03 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Mar 02 '23 12:03 github-actions[bot]

run buildall

liaoxin01 avatar Mar 04 '23 04:03 liaoxin01

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 04 '23 04:03 github-actions[bot]