doris icon indicating copy to clipboard operation
doris copied to clipboard

[Fix](Lightweight schema Change) query error caused by array default type is unsupported

Open ZhangYu0123 opened this issue 2 years ago • 12 comments

We have supportted array type default [], but when using lightweight schema Change to add column array type, query failed as follows:

image
  1. Fix "array default type is unsupported" error.
  2. Fix the default value filling assignment digit problem.

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

ZhangYu0123 avatar Mar 02 '23 07:03 ZhangYu0123

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 07:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 07:03 github-actions[bot]

run buildall

ZhangYu0123 avatar Mar 02 '23 07:03 ZhangYu0123

TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.29 seconds stream load tsv: 473 seconds loaded 74807831229 Bytes, about 150 MB/s stream load json: 40 seconds loaded 2358488459 Bytes, about 56 MB/s stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230304072544_clickbench_pr_108420.html

hello-stephen avatar Mar 02 '23 08:03 hello-stephen

Please add some regression test.

yiguolei avatar Mar 03 '23 00:03 yiguolei

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 03 '23 15:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 03 '23 15:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 03 '23 15:03 github-actions[bot]

run buildall

ZhangYu0123 avatar Mar 03 '23 16:03 ZhangYu0123

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 04 '23 04:03 github-actions[bot]

run buildall

ZhangYu0123 avatar Mar 04 '23 06:03 ZhangYu0123

run p1

ZhangYu0123 avatar Mar 04 '23 09:03 ZhangYu0123

PR approved by anyone and no changes requested.

github-actions[bot] avatar Mar 07 '23 03:03 github-actions[bot]

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Mar 07 '23 08:03 github-actions[bot]