doris icon indicating copy to clipboard operation
doris copied to clipboard

[Bug](Block compression) Fix bug if `config::compress_rowbatches=fals…

Open eldenmoon opened this issue 2 years ago • 7 comments

…e` then the block column values could be empty

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

eldenmoon avatar Mar 02 '23 06:03 eldenmoon

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 06:03 github-actions[bot]

run buildall

eldenmoon avatar Mar 02 '23 06:03 eldenmoon

TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.57 seconds stream load tsv: 475 seconds loaded 74807831229 Bytes, about 150 MB/s stream load json: 39 seconds loaded 2358488459 Bytes, about 57 MB/s stream load orc: 69 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230302075654_clickbench_pr_107031.html

hello-stephen avatar Mar 02 '23 07:03 hello-stephen

run p0

eldenmoon avatar Mar 02 '23 07:03 eldenmoon

run buildall

eldenmoon avatar Mar 02 '23 07:03 eldenmoon

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 07:03 github-actions[bot]

run p0

eldenmoon avatar Mar 02 '23 07:03 eldenmoon

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Mar 03 '23 02:03 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Mar 03 '23 02:03 github-actions[bot]