doris icon indicating copy to clipboard operation
doris copied to clipboard

[Enhancement] print profile for streamload

Open freemandealer opened this issue 2 years ago • 1 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Description

Currently only BrokerLoad and InsertInto support load profile. We need print profile info after StreamLoad, too.

What is profile? Why we need that? see link

Solution

When set global enable_profile=true, Streamload is actually profiled. However, this profile result is shown nowhere. We should print it out in the following function if is enabled.

be/src/runtime/plan_fragment_executor.cpp
void PlanFragmentExecutor::close()

Note that StreamLoad could be more frequent than other load jobs. Hence, to avoid too many profiles print in log, we need a control flag in be/src/common/config.h to allow the user turn on/off the print.

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

freemandealer avatar Feb 27 '23 04:02 freemandealer

please assignee to me

nextdreamblue avatar Feb 28 '23 02:02 nextdreamblue

@nextdreamblue any progress?

zhannngchen avatar Mar 15 '23 12:03 zhannngchen

@nextdreamblue any progress?

@zhannngchen sorry, i did some works like fixing user's bugs, did not do something for this issue maybe it is better to assignee to somebody for doris's future.

nextdreamblue avatar Mar 20 '23 03:03 nextdreamblue

@stalary please unassign it from @nextdreamblue. Thanks!

freemandealer avatar Mar 20 '23 04:03 freemandealer

Hi, I'd like to do this task. Please assign it to me.

gitccl avatar Mar 20 '23 15:03 gitccl