dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[DSIP-][Master] Add Continue_Other_Task_Chain FailureStrategy

Open topsli opened this issue 11 months ago • 5 comments

Search before asking

  • [X] I had searched in the DSIP and found no similar DSIP.

Motivation

Currently, the list of FailureStrategy only have END and CONTINUE. May be it should have another choice: Continue_Other_Task_Chain

/** * 0 ending process when some tasks failed. * 1 continue running when some tasks failed. * 2 one task failed will continue other running task chain. **/ END(0, "end"), CONTINUE(1, "continue"), Continue_Other_Task_Chain(2,"One task failed will continue other running task chain");

Design Detail

No response

Compatibility, Deprecation, and Migration Plan

No response

Test Plan

No response

Code of Conduct

topsli avatar Dec 23 '24 08:12 topsli

What is OTHER_CONTINUE , please add detail design and specific motivation.

ruanwenjun avatar Dec 23 '24 08:12 ruanwenjun

For example, a workflow process which have three branches like A,B,C. If branch B have a task failed, only affects the branch B. The other branch can continue to running. 1735091800531_3F1ABDBD-7137-4ea8-8054-BE3BBA8A5876 1735091773503_345302E8-292B-425b-892B-A5E3F8B83F01

topsli avatar Dec 25 '24 02:12 topsli

The status of the workflow instance also is failed. 1735092189761_A8ED0534-1E0E-42a1-8516-8A7134029AC8

topsli avatar Dec 25 '24 02:12 topsli

The current naming of our strategies is confusing It's better to have a more intuitive name e.g.

Continue_Other_Task("One task failed will continue other running task")
Continue_Other_Task_Chain("One task failed will continue other  running task chain")
Kill_Other_Task_Chain("One task failed will kill other running task chain")

Continue and OTHER_CONTINUE will make confuse.

ruanwenjun avatar Dec 25 '24 02:12 ruanwenjun

Continue_Other_Task_Chain("One task failed will continue other running task chain"). I think this one(Continue_Other_Task_Chain)is the best description.

topsli avatar Dec 25 '24 02:12 topsli