dolphinscheduler
dolphinscheduler copied to clipboard
[DSIP-74] Optimize workflow-related displays and filters
Search before asking
- [X] I had searched in the DSIP and found no similar DSIP.
Motivation
This DSIP involves two main parts, one is to add the creator and modifier field display to be able to clearly determine who is performing the operation. The other is to add filter items to add more customized filters for users. These two parts I intend to realize through two PRs For problems with more fields and severe small-screen extrusion, columns need to be dynamically displayed and hidden, and this problem is left to other PRs to implement These are my thoughts, let's see if you agree and I'll work on optimizing them if possible
Design Detail
1、Add creator and modifier fields to display:
Project
Workflow
Workflow Timing: createUser、modifyUser
Datasource
Datasource: createUser、modifyUser
Security
Tenant Manage: createUser、modifyUser
User Manage: createUser、modifyUser
Alarm Group Manage: createUser、modifyUser
Alarm Instance Manage: createUser、modifyUser
Worker Group Manage: createUser、modifyUser
Yarn Queue Manage: createUser、modifyUser
Environment Manage: createUser、modifyUser
Cluster Manage: createUser、modifyUser
K8S Namespace Manage: createUser、modifyUser
Token Manage: createUser、modifyUser
2、Add customized filters:
Project
Workflow
Workflow Definition: status、schedulePublishStatus、createTime
Workflow Timing: status
Datasource
Datasource: datasourceType
Increase the user-friendliness better with the above tweaks
Compatibility, Deprecation, and Migration Plan
Compatibility with latest version.
Test Plan
Test by UT.
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
I'm +1 on Workflow Definition.
For Workflow Timing, Considering that there are many fields displayed on the page now, adding two more fields is not so necessary, which is not very friendly to users with smaller resolutions. It would be better if there could be a better solution for this piece. For example, add a field option for the user to choose the display field. By default, we only show high priority fields.
I'm +1 on
Workflow Definition.For
Workflow Timing, Considering that there are many fields displayed on the page now, adding two more fields is not so necessary, which is not very friendly to users with smaller resolutions. It would be better if there could be a better solution for this piece. For example, add a field option for the user to choose the display field. By default, we only show high priority fields.
This program can be a good solution to the problem of many fields, the user can customize the choice of fields to display, you can look at this moving picture
This program can be a good solution to the problem of many fields, the user can customize the choice of fields to display, > you can look at this moving picture
Yes. That's what I mean.
This program can be a good solution to the problem of many fields, the user can customize the choice of fields to display, > you can look at this moving picture
Yes. That's what I mean.
For the optimization points I mentioned above, I make the following adjustments, see below
But for the column name dynamic display and hide (I am a front-end white, to achieve this for me a bit of a struggle), found that put in a bit out of place feeling, I feel that is not should be a single out of a pr, for the function of the field more than a little optimization of the unity of a little better, I would like to listen to your views?
But for the column name dynamic display and hide (I am a front-end white, to achieve this for me a bit of a struggle), found > that put in a bit out of place feeling, I feel that is not should be a single out of a pr, for the function of the field more than a > little optimization of the unity of a little better, I would like to listen to your views?
You can just achieve the Workflow Definition part of this issue. And The Workflow Timing part is waiting for other contributors to realize.
But for the column name dynamic display and hide (I am a front-end white, to achieve this for me a bit of a struggle), found > that put in a bit out of place feeling, I feel that is not should be a single out of a pr, for the function of the field more than a > little optimization of the unity of a little better, I would like to listen to your views?
You can just achieve the
Workflow Definitionpart of this issue. And TheWorkflow Timingpart is waiting for other contributors to realize. I'm going to add status filtering and corresponding creator and modifier logic to the workflow timings, can the front-end not show them for now, or are they not necessary?
But for the column name dynamic display and hide (I am a front-end white, to achieve this for me a bit of a struggle), found > that put in a bit out of place feeling, I feel that is not should be a single out of a pr, for the function of the field more than a > little optimization of the unity of a little better, I would like to listen to your views?
You can just achieve the
Workflow Definitionpart of this issue. And TheWorkflow Timingpart is waiting for other contributors to realize.
I think it's a good idea to add this to these.
I think it's a good idea to add this to these.
I think this is unnecessary especially in prod environment.
I think it's a good idea to add this to these.
I think this is unnecessary especially in prod environment.
Okay, then in read more of the other comments, otherwise writing and not passing is the same as not writing at all😂
I've just described the adjustments, take a look, anything else you want to add? @SbloodyS @ruanwenjun
I think it's a good idea to add this to these.