dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Chore] remove unuse resource query

Open caishunfeng opened this issue 1 year ago • 3 comments
trafficstars

Purpose of the pull request

Remove unuse listResource and listResourcesByUser method.

Brief change log

ProcessDefinitionMapper and TaskDefinitionMapper

Verify this pull request

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

caishunfeng avatar Jun 29 '24 01:06 caishunfeng

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.15%. Comparing base (565a917) to head (501c957). Report is 5 commits behind head on dev.

:exclamation: Current head 501c957 differs from pull request most recent head 8899345

Please upload reports for the commit 8899345 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16239      +/-   ##
============================================
- Coverage     41.17%   41.15%   -0.03%     
+ Complexity     5093     5091       -2     
============================================
  Files          1391     1391              
  Lines         43803    43803              
  Branches       4645     4645              
============================================
- Hits          18038    18028      -10     
- Misses        23997    24006       +9     
- Partials       1768     1769       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 29 '24 02:06 codecov-commenter

We can directly remove listResources, this method is never used.

Good advice, had remove these unuse mapper method.

caishunfeng avatar Jun 29 '24 03:06 caishunfeng

Please retry analysis of this Pull-Request directly on SonarCloud

sonarqubecloud[bot] avatar Jul 04 '24 01:07 sonarqubecloud[bot]