dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[DSIP-39][parameter] Improvement startup parameters/global parameters/project parameters data type

Open sdhzwc opened this issue 1 year ago • 12 comments

close #15936

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

sdhzwc avatar May 10 '24 01:05 sdhzwc

Please add the docs。 @sdhzwc

Yesterday I got feedback that the front-end compilation failed, so I'll improve the documentation when I've solved this problem.

sdhzwc avatar May 10 '24 01:05 sdhzwc

Yesterday I got feedback that the front-end compilation failed, so I'll improve the documentation when I've solved this problem.

pnpm run build:prod command failed. You can test it locally.

SbloodyS avatar May 10 '24 01:05 SbloodyS

Codecov Report

Attention: Patch coverage is 33.33333% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 40.60%. Comparing base (dbd790d) to head (272fa28). Report is 1 commits behind head on dev.

:exclamation: Current head 272fa28 differs from pull request most recent head bdbb330

Please upload reports for the commit bdbb330 to get more accurate results.

Files Patch % Lines
...scheduler/plugin/task/api/utils/PropertyUtils.java 0.00% 14 Missing :warning:
...eduler/service/expand/CuringParamsServiceImpl.java 66.66% 2 Missing and 1 partial :warning:
...cheduler/api/service/impl/ExecutorServiceImpl.java 0.00% 1 Missing and 1 partial :warning:
...inscheduler/api/controller/ExecutorController.java 50.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15967      +/-   ##
============================================
- Coverage     40.63%   40.60%   -0.03%     
+ Complexity     5222     5221       -1     
============================================
  Files          1380     1381       +1     
  Lines         46066    46080      +14     
  Branches       4916     4917       +1     
============================================
- Hits          18718    18712       -6     
- Misses        25423    25443      +20     
  Partials       1925     1925              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 10 '24 02:05 codecov-commenter

I tried to compile the frontend locally but failed.

image

ruanwenjun avatar May 10 '24 02:05 ruanwenjun

I tried to compile the frontend locally but failed.

image

I tried to compile the frontend locally but failed.

image

My local is windows environment, using the same method, but reported a bunch of errors, can not lock the problem, but by watching you send the error, I found that onClearSearchTaskType method is not used, I removed, it should be good, or you run a little!

sdhzwc avatar May 10 '24 03:05 sdhzwc

Yesterday I got feedback that the front-end compilation failed, so I'll improve the documentation when I've solved this problem.

pnpm run build:prod command failed. You can test it locally.

done

sdhzwc avatar May 10 '24 07:05 sdhzwc

The database schema sync check failed with pg

image I don't see an error related to the code I wrote I successfully added the SQL statement.

sdhzwc avatar May 14 '24 10:05 sdhzwc

The database schema sync check failed with pg

image I don't see an error related to the code I wrote I successfully added the SQL statement.

This is a history problem, not related to this PR.

ruanwenjun avatar May 14 '24 10:05 ruanwenjun

The database schema sync check failed with pg

image I don't see an error related to the code I wrote I successfully added the SQL statement.

This may due to a history problem, I submit https://github.com/apache/dolphinscheduler/pull/15995 to fix this.

ruanwenjun avatar May 14 '24 11:05 ruanwenjun

Since the next release will from dev, so I change the milestone to 3.2.2, otherwise this pr cannot be merged before we release 3.2.2

ruanwenjun avatar May 15 '24 03:05 ruanwenjun

@ruanwenjun That should do it.

sdhzwc avatar May 16 '24 01:05 sdhzwc

Please fix UT. @sdhzwc

SbloodyS avatar May 21 '24 05:05 SbloodyS

Quality Gate Failed Quality Gate failed

Failed conditions
36.8% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 21 '24 07:05 sonarqubecloud[bot]