dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Improvement] Optimize ServerLoadProtection.

Open Zzih96 opened this issue 1 year ago • 4 comments

Purpose of the pull request

  • Fix the issue where configurations couldn't load properly due to case sensitivity
  • add configuration validation
  • and modify error log messages.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Zzih96 avatar Apr 08 '24 10:04 Zzih96

Are you sure there will exist case sensitivity problem? add configuration LGTM, some change should already exist in https://github.com/apache/dolphinscheduler/pull/15803

ruanwenjun avatar Apr 08 '24 14:04 ruanwenjun

Please resolve the conflicts.

ruanwenjun avatar Apr 09 '24 06:04 ruanwenjun

LGTM

In the Kubernetes environment, I couldn't inject MASTER_SERVER_LOAD_PROTECTION_MAX_JVM_MEMORY_USAGE_PERCENTAGE_THRESHOLDS intomaxJVMMemoryUsagePercentageThresholds as configured. However, modifying it tomaxJvmMemoryUsagePercentageThresholds does allow successful injection. I suspect this might be related to the getters and setters generated by Lombok.

Zzih96 avatar Apr 09 '24 07:04 Zzih96

Please resolve the conflicts.

I'll give it a try.

Zzih96 avatar Apr 09 '24 07:04 Zzih96

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Aug 08 '24 00:08 github-actions[bot]

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

github-actions[bot] avatar Aug 16 '24 00:08 github-actions[bot]