dolphinscheduler
dolphinscheduler copied to clipboard
[DSIP] Support ssl at RPC
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md
Since this will import new feature, please create a DSIP issue, you can follow https://github.com/apache/dolphinscheduler/issues/14102
Could you please add doc and ut for this?
of course ,I will add it recently
I want to wait until my code structure is ok and everyone’s review has passed before I add UT. @ruanwenjun @rickchengx
The documentation on how to use SSL also needs to be updated. At the same time, the Helm charts need to be updated to support this capability. @fuchanghai
The documentation on how to use SSL also needs to be updated. At the same time, the Helm charts need to be updated to support this capability. @fuchanghai
get
Codecov Report
Attention: Patch coverage is 53.84615% with 18 lines in your changes are missing coverage. Please review.
Project coverage is 39.86%. Comparing base (
60b019b) to head (626be70).
:exclamation: Current head 626be70 differs from pull request most recent head 3c11124. Consider uploading reports for the commit 3c11124 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## dev #15802 +/- ##
============================================
- Coverage 39.93% 39.86% -0.08%
+ Complexity 5081 5061 -20
============================================
Files 1369 1369
Lines 45635 45662 +27
Branches 4869 4872 +3
============================================
- Hits 18224 18201 -23
- Misses 25513 25558 +45
- Partials 1898 1903 +5
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Quality Gate passed
Issues
8 New issues
0 Accepted issues
Measures
0 Security Hotspots
63.3% Coverage on New Code
0.0% Duplication on New Code