dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[DSIP] Support ssl at RPC

Open fuchanghai opened this issue 1 year ago • 7 comments

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

fuchanghai avatar Apr 06 '24 14:04 fuchanghai

Since this will import new feature, please create a DSIP issue, you can follow https://github.com/apache/dolphinscheduler/issues/14102

ruanwenjun avatar Apr 06 '24 15:04 ruanwenjun

Could you please add doc and ut for this?

of course ,I will add it recently

fuchanghai avatar Apr 07 '24 02:04 fuchanghai

I want to wait until my code structure is ok and everyone’s review has passed before I add UT. @ruanwenjun @rickchengx

fuchanghai avatar Apr 14 '24 14:04 fuchanghai

The documentation on how to use SSL also needs to be updated. At the same time, the Helm charts need to be updated to support this capability. @fuchanghai

Gallardot avatar Apr 15 '24 12:04 Gallardot

The documentation on how to use SSL also needs to be updated. At the same time, the Helm charts need to be updated to support this capability. @fuchanghai

get

fuchanghai avatar Apr 16 '24 03:04 fuchanghai

Codecov Report

Attention: Patch coverage is 53.84615% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 39.86%. Comparing base (60b019b) to head (626be70).

:exclamation: Current head 626be70 differs from pull request most recent head 3c11124. Consider uploading reports for the commit 3c11124 to get more accurate results

Files Patch % Lines
...duler/extract/base/client/NettyRemotingClient.java 27.27% 6 Missing and 2 partials :warning:
...duler/extract/base/server/NettyRemotingServer.java 27.27% 6 Missing and 2 partials :warning:
...e/dolphinscheduler/server/master/MasterServer.java 0.00% 1 Missing :warning:
...e/dolphinscheduler/server/worker/WorkerServer.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15802      +/-   ##
============================================
- Coverage     39.93%   39.86%   -0.08%     
+ Complexity     5081     5061      -20     
============================================
  Files          1369     1369              
  Lines         45635    45662      +27     
  Branches       4869     4872       +3     
============================================
- Hits          18224    18201      -23     
- Misses        25513    25558      +45     
- Partials       1898     1903       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 09 '24 08:05 codecov-commenter