dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Improvement-15701][flink_task] supported variables of flink tasks

Open bajiaolong opened this issue 1 year ago • 9 comments

close #15701

  1. Exclude guava information from guava-retrying dependencies,Unable to download 'com.google.guava:guava-parent:pom:31.1.0.redhat-00001 'during packaging, this version of this library does not exist at all

  2. Delete TaskExecutionContext definedParams member variable in this class, which has not been set,and modify other calls with this reference to prepareParamsMap

  3. Modify the getProperties in the Abstract Yarn Task subclass to prepareParamsMap

Purpose of the pull request

does not take effect when flink uses parameter variables

Brief change log

  • 1.Exclude guava information from guava-retrying dependencies,Unable to download 'com.google.guava:guava-parent:pom:31.1.0.redhat-00001 'during packaging, this version of this library does not exist at all

    1. Delete TaskExecutionContext definedParams member variable in this class, which has not been set,and modify other calls with this reference to prepareParamsMap
    1. Modify the getProperties in the Abstract Yarn Task subclass to prepareParamsMap

Verify this pull request

This pull request is code cleanup without any test coverage.

bajiaolong avatar Mar 13 '24 07:03 bajiaolong

@SbloodyS Can this milestone be put in 3.2.2? Although this is an optimization item, it is also a bug. I will deal with it quickly.

bajiaolong avatar Mar 14 '24 03:03 bajiaolong

@SbloodyS Can this milestone be put in 3.2.2? Although this is an optimization item, it is also a bug. I will deal with it quickly.

It's more like a feature instead of bug. Minor version updates do not include features.

SbloodyS avatar Mar 14 '24 03:03 SbloodyS

@SbloodyS Can this milestone be put in 3.2.2? Although this is an optimization item, it is also a bug. I will deal with it quickly.

It's more like a feature instead of bug. Minor version updates do not include features.

received, I want to know when the next version will be released and what are the Law?

bajiaolong avatar Mar 14 '24 03:03 bajiaolong

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 39.11%. Comparing base (0419543) to head (2779828).

:exclamation: Current head 2779828 differs from pull request most recent head 1fe4274. Consider uploading reports for the commit 1fe4274 to get more accurate results

Files Patch % Lines
.../dolphinscheduler/plugin/task/flink/FileUtils.java 0.00% 5 Missing :warning:
...inscheduler/plugin/task/flink/FlinkStreamTask.java 0.00% 1 Missing :warning:
.../dolphinscheduler/plugin/task/flink/FlinkTask.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15708      +/-   ##
============================================
- Coverage     39.11%   39.11%   -0.01%     
+ Complexity     4887     4886       -1     
============================================
  Files          1326     1326              
  Lines         45206    45209       +3     
  Branches       4818     4818              
============================================
  Hits          17683    17683              
- Misses        25635    25637       +2     
- Partials       1888     1889       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 14 '24 03:03 codecov-commenter

received, I want to know when the next version will be released and what are the Law?

There is currently no release plan for version 3.3.0. For version rules, you can take a look at https://dev.to/ndrohith/xyz-of-versioning-47op. @bajiaolong

SbloodyS avatar Mar 14 '24 05:03 SbloodyS

received, I want to know when the next version will be released and what are the Law?

There is currently no release plan for version 3.3.0. For version rules, you can take a look at https://dev.to/ndrohith/xyz-of-versioning-47op. @bajiaolong

ths

bajiaolong avatar Mar 14 '24 06:03 bajiaolong

Quality Gate Failed Quality Gate failed

Failed conditions
20.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Apr 03 '24 02:04 sonarqubecloud[bot]

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Aug 02 '24 00:08 github-actions[bot]