dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Improvement][UT] Improve Worker runner coverage

Open pegasas opened this issue 1 year ago • 8 comments

Purpose of the pull request

resolve: https://github.com/apache/dolphinscheduler/issues/15396

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

pegasas avatar Jan 04 '24 10:01 pegasas

Hi, @pegasas , please fix CI

rickchengx avatar Feb 05 '24 02:02 rickchengx

Hi, @pegasas , please fix CI

It seems there's a lot refactor after last merge. I will fix & re-commit.

pegasas avatar Feb 05 '24 02:02 pegasas

Hi, @pegasas , please fix CI

It seems there's a lot refactor after last merge. I will fix & re-commit.

fixed.

pegasas avatar Feb 05 '24 13:02 pegasas

@pegasas please check the failed CI

rickchengx avatar Feb 19 '24 03:02 rickchengx

@pegasas please check the failed CI

image Done. run spotless successfully in my local

pegasas avatar Feb 19 '24 07:02 pegasas

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5213290) 38.58% compared to head (cd7da69) 38.94%.

:exclamation: Current head cd7da69 differs from pull request most recent head 9c43999. Consider uploading reports for the commit 9c43999 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15428      +/-   ##
============================================
+ Coverage     38.58%   38.94%   +0.36%     
- Complexity     4784     4832      +48     
============================================
  Files          1312     1312              
  Lines         44978    45009      +31     
  Branches       4819     4819              
============================================
+ Hits          17355    17531     +176     
+ Misses        25733    25574     -159     
- Partials       1890     1904      +14     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 20 '24 02:02 codecov-commenter

will merge tomorrow if no more comments

rickchengx avatar Feb 21 '24 08:02 rickchengx