dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Fix-15373] [SQL Task]Hive jdbc implementation does not support multi SQL sentences within a single PreparedStatement.

Open iamcaoxudong opened this issue 1 year ago • 3 comments
trafficstars

Purpose of the pull request

resolves https://github.com/apache/dolphinscheduler/issues/15373

Brief change log

Hive JDBC implementation does not support multi statements in on PreparedStatement.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

iamcaoxudong avatar Dec 28 '23 07:12 iamcaoxudong

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (86ef966) 38.14% compared to head (2c5ef0b) 38.15%.

:exclamation: Current head 2c5ef0b differs from pull request most recent head 38f9e4a. Consider uploading reports for the commit 38f9e4a to get more accurate results

Files Patch % Lines
.../org/apache/dolphinscheduler/spi/enums/DbType.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15375   +/-   ##
=========================================
  Coverage     38.14%   38.15%           
- Complexity     4704     4705    +1     
=========================================
  Files          1304     1304           
  Lines         44820    44820           
  Branches       4805     4805           
=========================================
+ Hits          17098    17099    +1     
  Misses        25870    25870           
+ Partials       1852     1851    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 30 '24 10:01 codecov-commenter

Hi, @iamcaoxudong , maybe we could just delete this method, since it is not used anymore after #15367 as you mentioned

rickchengx avatar Feb 05 '24 02:02 rickchengx

Hi, @iamcaoxudong , maybe we could just delete this method, since it is not used anymore after #15367 as you mentioned

+1, @iamcaoxudong can you update this pr?

caishunfeng avatar Mar 04 '24 09:03 caishunfeng

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Jul 03 '24 00:07 github-actions[bot]

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

github-actions[bot] avatar Jul 10 '24 00:07 github-actions[bot]