dolphinscheduler
dolphinscheduler copied to clipboard
[Improvement] Remove redundant and security vulnerable code
Purpose of the pull request
- Remove redundant and potentially risky code.
- Users could use
K8S connectioninConnection(Datasource) Centerto submit task to K8S clusters. There is absolutely no need to have a K8S cluster management console in Dolphin, which only leads to potential vulnerabilities.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
5b6b0ce) 37.81% compared to head (4316f2d) 37.55%.
:exclamation: Current head 4316f2d differs from pull request most recent head 4373053. Consider uploading reports for the commit 4373053 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## dev #15204 +/- ##
============================================
- Coverage 37.81% 37.55% -0.26%
+ Complexity 4680 4600 -80
============================================
Files 1304 1298 -6
Lines 44932 44592 -340
Branches 4810 4765 -45
============================================
- Hits 16989 16745 -244
+ Misses 26094 26028 -66
+ Partials 1849 1819 -30
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Do we have any related docs to remove?
Do we have any related docs to remove?
Good catch, on the way : )
Just figured out in spark / flink tasks, there are still places using cluster management stuff. I need to refactor related code to completely get rid of k8s management stuff.
Thanks for cleaning this kind of code.
Quality Gate passed
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.
NO stale
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.







