dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Improvement][pom]chore: update mysql dependency

Open Gallardot opened this issue 2 years ago • 8 comments

Purpose of the pull request

ref: https://github.com/apache/dolphinscheduler/issues/14683

ref: https://dev.mysql.com/doc/connector-j/en/connector-j-installing-maven.html

You can link the Connector/J library to your project by adding the following dependency in your pom.xml file:

<dependency>
    <groupId>com.mysql</groupId>
    <artifactId>mysql-connector-j</artifactId>
    <version>x.y.z</version>
</dependency>

Note For Connector/J 8.0.29 and earlier, use the following Maven coordinates:

groupId: mysql

artifactId: mysql-connector-java

now we using Connector/J 8.4.0

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Gallardot avatar Aug 11 '23 09:08 Gallardot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.79%. Comparing base (ebcdaeb) to head (8130f2e).

:exclamation: Current head 8130f2e differs from pull request most recent head 2ad967a. Consider uploading reports for the commit 2ad967a to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #14736   +/-   ##
=========================================
  Coverage     39.79%   39.79%           
  Complexity     5044     5044           
=========================================
  Files          1353     1353           
  Lines         45619    45619           
  Branches       4891     4891           
=========================================
  Hits          18156    18156           
  Misses        25553    25553           
  Partials       1910     1910           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 11 '23 09:08 codecov-commenter

Dependency license check failed, and dependency +mysql-connector-java-8.0.30.jar appears, it's weird.

Radeity avatar Aug 11 '23 17:08 Radeity

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 15 '23 01:08 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 24 '23 16:11 sonarqubecloud[bot]

The link https://dev.mysql.com/doc/connector-j/8.1/en/connector-j-installing-maven.html is 404 and it seems this pr might bring incompatible problem.

ruanwenjun avatar Apr 28 '24 02:04 ruanwenjun

The link https://dev.mysql.com/doc/connector-j/8.1/en/connector-j-installing-maven.html is 404 and it seems this pr might bring incompatible problem.

@ruanwenjun

The current 8.0.33 version also has a cve vulnerability, updated to the latest 8.4.0 version. ref link update to https://dev.mysql.com/doc/connector-j/en/connector-j-installing-maven.html

Gallardot avatar May 01 '24 16:05 Gallardot

Please retry analysis of this Pull-Request directly on SonarCloud

sonarqubecloud[bot] avatar May 01 '24 16:05 sonarqubecloud[bot]

The current version of mysql's CVE is not higher than 7 points, we do not need to upgrade it.

SbloodyS avatar Jun 28 '24 03:06 SbloodyS