closed by #9980

Aug 01 '22 07:08 brave-lee

Please remove the deprecated class HeartBeatTask.

Aug 02 '22 08:08 ruanwenjun

Please remove the deprecated class HeartBeatTask.

Please check, it has been removed here

Aug 02 '22 08:08 brave-lee

Please remove the deprecated class HeartBeatTask.

Please check, it has been removed here

It means to remove the org.apache.dolphinscheduler.server.registry.HeartBeatTask class, if we no longer use it.

BTW, I think the name MasterHeartBeatListener and WorkerHeartBeatListener seems strange, because they are schedule runnable task, not listener.

Aug 11 '22 01:08 caishunfeng

Codecov Report

Merging #11232 (077dfb8) into dev (8e21c38) will decrease coverage by 0.60%. The diff coverage is 63.04%.

@@             Coverage Diff              @@
##                dev   #11232      +/-   ##
============================================
- Coverage     40.15%   39.55%   -0.61%     
+ Complexity     4953     4627     -326     
============================================
  Files           988      981       -7     
  Lines         37738    37216     -522     
  Branches       4149     4159      +10     
============================================
- Hits          15153    14719     -434     
+ Misses        21044    20976      -68     
+ Partials       1541     1521      -20

Impacted Files	Coverage Δ
...er/server/master/registry/MasterHeartBeatTask.java	`38.46% <38.46%> (ø)`
...er/server/worker/registry/WorkerHeartBeatTask.java	`68.96% <80.00%> (ø)`
...r/server/master/registry/MasterRegistryClient.java	`44.30% <100.00%> (-0.82%)`	:arrow_down:
...r/server/worker/registry/WorkerRegistryClient.java	`58.06% <100.00%> (-0.67%)`	:arrow_down:
...e/dolphinscheduler/dao/entity/ProcessInstance.java	`0.00% <0.00%> (-65.57%)`	:arrow_down:
...olphinscheduler/plugin/task/emr/EmrParameters.java	`0.00% <0.00%> (-50.00%)`	:arrow_down:
...heduler/plugin/task/jupyter/JupyterParameters.java	`33.33% <0.00%> (-46.67%)`	:arrow_down:
...inscheduler/server/worker/config/WorkerConfig.java	`0.00% <0.00%> (-46.16%)`	:arrow_down:
...duler/plugin/task/zeppelin/ZeppelinParameters.java	`33.33% <0.00%> (-36.67%)`	:arrow_down:
...inscheduler/server/master/config/MasterConfig.java	`0.00% <0.00%> (-33.34%)`	:arrow_down:
... and 181 more