dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[doc] Use Rainbond deployment DolphinScheduler Cluster

Open zzzhangqi opened this issue 3 years ago • 23 comments

Signed-off-by: Qi Zhang [email protected]

Purpose of the pull request

This pull request add new installation,use Rainbond deploy DolphinScheduler cluster.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

zzzhangqi avatar Jul 13 '22 13:07 zzzhangqi

One more thing, maybe we should put this doc in new section named integrated better than Installation

docs/docs/zh/guide/installation/integrated/rainbond.md Put the doc in this directory?

zzzhangqi avatar Jul 14 '22 05:07 zzzhangqi

@zhongjiajie proposal has been dealt with.please review

zzzhangqi avatar Jul 14 '22 12:07 zzzhangqi

I had approved to run CI.

SbloodyS avatar Jul 16 '22 04:07 SbloodyS

@SbloodyS I don't quite understand why ci didn't pass.Can you give me some guidance?

zzzhangqi avatar Jul 16 '22 18:07 zzzhangqi

@SbloodyS I don't quite understand why ci didn't pass.Can you give me some guidance?

Sorry for late reply. You can find the detail of errors in https://github.com/apache/dolphinscheduler/runs/7368120405?check_suite_focus=true. And you can find this url in the Dead Link's Detail.

SbloodyS avatar Jul 25 '22 02:07 SbloodyS

@SbloodyS All checks have passed.Please review

zzzhangqi avatar Jul 25 '22 02:07 zzzhangqi

@zhongjiajie @EricGao888 PTAL.

SbloodyS avatar Jul 25 '22 02:07 SbloodyS

@zhongjiajie @EricGao888 PTAL.

Hi @zzzhangqi, I just added some comments, thx

EricGao888 avatar Jul 25 '22 03:07 EricGao888

Hi @EricGao888 ,I have revised your suggest.please approve run ci. 🤗

zzzhangqi avatar Jul 25 '22 09:07 zzzhangqi

Hi @EricGao888 ,I have revised your suggest.please approve run ci. 🤗

@zzzhangqi Hi, thx for the update. CI already seems running. GitHub CI has been extremely slow recently, all we could do is wait. 🤣

EricGao888 avatar Jul 25 '22 09:07 EricGao888

@EricGao888 Hi, All checks have passed.Please again review.😜

zzzhangqi avatar Jul 25 '22 13:07 zzzhangqi

LGTM

Thanks,This pr auto merge?

zzzhangqi avatar Jul 25 '22 14:07 zzzhangqi

LGTM

Thanks,This pr auto merge?

@zzzhangqi We need two approvals here to get it merged. Maybe you could ping another committer if you're hurried to get it in : )

EricGao888 avatar Jul 25 '22 14:07 EricGao888

LGTM

Thanks,This pr auto merge?

@zzzhangqi We need two approvals here to get it merged. Maybe you could ping another committer if you're hurried to get it in : )

Thanks 😘

zzzhangqi avatar Jul 25 '22 14:07 zzzhangqi

@zhongjiajie Hi, Please review, Thanks.

zzzhangqi avatar Jul 25 '22 14:07 zzzhangqi

And BTW, I think it belong to section integration instead of deployment, maybe we should add a new sidebar named integration to hold this or other content like that, WDTY @EricGao888 @zzzhangqi

zhongjiajie avatar Jul 26 '22 11:07 zhongjiajie

LGTM

Thanks,This pr auto merge?

@zzzhangqi We need two approvals here to get it merged. Maybe you could ping another committer if you're hurried to get it in : )

FYI, @EricGao888 currently we only need one approval to merge PR

zhongjiajie avatar Jul 26 '22 11:07 zhongjiajie

And BTW, I think it belong to section integration instead of deployment, maybe we should add a new sidebar named integration to hold this or other content like that, WDTY @EricGao888 @zzzhangqi

Sounds good to me.

EricGao888 avatar Jul 26 '22 11:07 EricGao888

Can we remove img monitor-dolphinscheduler.png and homepage-dolphinscheduler.png and it related content? it is duplicate to exists https://dolphinscheduler.apache.org/en-us/docs/dev/user_doc/guide/homepage.html and https://dolphinscheduler.apache.org/en-us/docs/dev/user_doc/guide/monitor.html

maybe you add a hyper link to above link, or directly use pure markdown content without img

No problem

zzzhangqi avatar Jul 26 '22 14:07 zzzhangqi

And BTW, I think it belong to section integration instead of deployment, maybe we should add a new sidebar named integration to hold this or other content like that, WDTY @EricGao888 @zzzhangqi

move to dev/user_doc/guide/installation/integration ? @EricGao888 @zhongjiajie Is that okay?

or dev/user_doc/integration/rainbond.html first level menu?

zzzhangqi avatar Jul 26 '22 14:07 zzzhangqi

Hi @zhongjiajie , May I ask how to deal with this PR next? What should I do?

zzzhangqi avatar Aug 04 '22 09:08 zzzhangqi

And BTW, I think it belong to section integration instead of deployment, maybe we should add a new sidebar named integration to hold this or other content like that, WDTY @EricGao888 @zzzhangqi

move to dev/user_doc/guide/installation/integration ? @EricGao888 @zhongjiajie Is that okay?

or dev/user_doc/integration/rainbond.html first level menu?

I prefer dev/user_doc/integration/rainbond.html. WDYT @SbloodyS @zhongjiajie

EricGao888 avatar Aug 04 '22 09:08 EricGao888

And BTW, I think it belong to section integration instead of deployment, maybe we should add a new sidebar named integration to hold this or other content like that, WDTY @EricGao888 @zzzhangqi

move to dev/user_doc/guide/installation/integration ? @EricGao888 @zhongjiajie Is that okay? or dev/user_doc/integration/rainbond.html first level menu?

I prefer dev/user_doc/integration/rainbond.html. WDYT @SbloodyS @zhongjiajie

I agree, I will modify according to dev/user_doc/integration/rainbond.html? @SbloodyS @zhongjiajie @EricGao888

zzzhangqi avatar Aug 08 '22 10:08 zzzhangqi

How to deal with this PR next? @EricGao888 @SbloodyS @zhongjiajie

zzzhangqi avatar Aug 14 '22 07:08 zzzhangqi

I have modified @EricGao888 , Please review

zzzhangqi avatar Aug 14 '22 07:08 zzzhangqi

By adding different integrations with DS, it helps enrich the ecosystem. If there are no more comments on this PR, I will proceed to merge it. @SbloodyS @zhongjiajie

EricGao888 avatar Aug 15 '22 06:08 EricGao888

@zzzhangqi Thanks for contributing this to DS! Good job!

EricGao888 avatar Aug 15 '22 06:08 EricGao888

@SbloodyS Please optimize the commits log when merging PR.

image

ruanwenjun avatar Aug 15 '22 08:08 ruanwenjun

@SbloodyS Please optimize the commits log when merging PR.

image

I'll take care of it next time. Thanks.

SbloodyS avatar Aug 15 '22 08:08 SbloodyS