dolphinscheduler
dolphinscheduler copied to clipboard
[doc] Use Rainbond deployment DolphinScheduler Cluster
Signed-off-by: Qi Zhang [email protected]
Purpose of the pull request
This pull request add new installation,use Rainbond deploy DolphinScheduler cluster.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
One more thing, maybe we should put this doc in new section named
integratedbetter thanInstallation
docs/docs/zh/guide/installation/integrated/rainbond.md
Put the doc in this directory?
@zhongjiajie proposal has been dealt with.please review
I had approved to run CI.
@SbloodyS I don't quite understand why ci didn't pass.Can you give me some guidance?
@SbloodyS I don't quite understand why ci didn't pass.Can you give me some guidance?
Sorry for late reply. You can find the detail of errors in https://github.com/apache/dolphinscheduler/runs/7368120405?check_suite_focus=true. And you can find this url in the Dead Link's Detail.
@SbloodyS All checks have passed.Please review
@zhongjiajie @EricGao888 PTAL.
@zhongjiajie @EricGao888 PTAL.
Hi @zzzhangqi, I just added some comments, thx
Hi @EricGao888 ,I have revised your suggest.please approve run ci. 🤗
Hi @EricGao888 ,I have revised your suggest.please approve run ci. 🤗
@zzzhangqi Hi, thx for the update. CI already seems running. GitHub CI has been extremely slow recently, all we could do is wait. 🤣
@EricGao888 Hi, All checks have passed.Please again review.😜
LGTM
Thanks,This pr auto merge?
LGTM
Thanks,This pr auto merge?
@zzzhangqi We need two approvals here to get it merged. Maybe you could ping another committer if you're hurried to get it in : )
LGTM
Thanks,This pr auto merge?
@zzzhangqi We need two approvals here to get it merged. Maybe you could ping another committer if you're hurried to get it in : )
Thanks 😘
@zhongjiajie Hi, Please review, Thanks.
And BTW, I think it belong to section integration instead of deployment, maybe we should add a new sidebar named integration to hold this or other content like that, WDTY @EricGao888 @zzzhangqi
LGTM
Thanks,This pr auto merge?
@zzzhangqi We need two approvals here to get it merged. Maybe you could ping another committer if you're hurried to get it in : )
FYI, @EricGao888 currently we only need one approval to merge PR
And BTW, I think it belong to section
integrationinstead ofdeployment, maybe we should add a new sidebar namedintegrationto hold this or other content like that, WDTY @EricGao888 @zzzhangqi
Sounds good to me.
Can we remove img
monitor-dolphinscheduler.pngandhomepage-dolphinscheduler.pngand it related content? it is duplicate to exists https://dolphinscheduler.apache.org/en-us/docs/dev/user_doc/guide/homepage.html and https://dolphinscheduler.apache.org/en-us/docs/dev/user_doc/guide/monitor.htmlmaybe you add a hyper link to above link, or directly use pure markdown content without img
No problem
And BTW, I think it belong to section
integrationinstead ofdeployment, maybe we should add a new sidebar namedintegrationto hold this or other content like that, WDTY @EricGao888 @zzzhangqi
move to dev/user_doc/guide/installation/integration ? @EricGao888 @zhongjiajie Is that okay?
or dev/user_doc/integration/rainbond.html first level menu?
Hi @zhongjiajie , May I ask how to deal with this PR next? What should I do?
And BTW, I think it belong to section
integrationinstead ofdeployment, maybe we should add a new sidebar namedintegrationto hold this or other content like that, WDTY @EricGao888 @zzzhangqimove to
dev/user_doc/guide/installation/integration? @EricGao888 @zhongjiajie Is that okay?or
dev/user_doc/integration/rainbond.htmlfirst level menu?
I prefer dev/user_doc/integration/rainbond.html. WDYT @SbloodyS @zhongjiajie
And BTW, I think it belong to section
integrationinstead ofdeployment, maybe we should add a new sidebar namedintegrationto hold this or other content like that, WDTY @EricGao888 @zzzhangqimove to
dev/user_doc/guide/installation/integration? @EricGao888 @zhongjiajie Is that okay? ordev/user_doc/integration/rainbond.htmlfirst level menu?I prefer
dev/user_doc/integration/rainbond.html. WDYT @SbloodyS @zhongjiajie
I agree, I will modify according to dev/user_doc/integration/rainbond.html? @SbloodyS @zhongjiajie @EricGao888
How to deal with this PR next? @EricGao888 @SbloodyS @zhongjiajie
I have modified @EricGao888 , Please review
By adding different integrations with DS, it helps enrich the ecosystem. If there are no more comments on this PR, I will proceed to merge it. @SbloodyS @zhongjiajie
@zzzhangqi Thanks for contributing this to DS! Good job!
@SbloodyS Please optimize the commits log when merging PR.
@SbloodyS Please optimize the commits log when merging PR.
![]()
I'll take care of it next time. Thanks.