Add ANSI support for Add

[andygrove]

What is the problem the feature request solves?

Spark has specific handling of overflows when ANSI mode is enabled and we need to add the same in Comet.

Describe the potential solution

No response

Additional context

No response

[planga82]

I want to try this one!

[dharanad]

Hello @planga82

Just wanted to check in and see if you're still working on this task. I'm actually working on the subtraction variant of the same task, and I thought it might be helpful to chat about our approaches. There's a good chance one of our solutions could build upon the other!

Let me know if you're available to discuss sometime.

Here is the Draft PR: #593

[planga82]

Hello @dharanad Yes, I'm working on it, but I don't have much time, so I'm going slow. The structure of the solution I'm working on is quite similar to yours, basically a wrapper. In Spark, the implementation uses the Java Math.addExact function. Basically, I'm trying to reproduce that implementation using Datafusion functions. Thanks for sharing your PR, I will keep an eye on your progress to adapt my solution to be compatible with your code, and I will create a PR when I achive a working solution.

[coderfender]

@andygrove This can be closed now since https://github.com/apache/datafusion-comet/pull/2136/ is merged to main