datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard

Add ANSI support in SUM and AVG

Open andygrove opened this issue 1 year ago • 7 comments

What is the problem the feature request solves?

Spark has specific handling of overflows when ANSI mode is enabled and we need to add the same in Comet.

Describe the potential solution

No response

Additional context

No response

andygrove avatar Jun 06 '24 14:06 andygrove

hello @andygrove i want to work on this issue, can you please assign it to me

dharanad avatar Jun 20 '24 19:06 dharanad

Thanks @dharanad.

viirya avatar Jun 20 '24 19:06 viirya

@dharanad Checking if you are still working on this, if not I can take a stab at it. Thanks.

SatyaKuppam avatar Dec 04 '24 01:12 SatyaKuppam

@SatyaKuppam go ahead.

dharanad avatar Dec 04 '24 05:12 dharanad

Picking this up

coderfender avatar Sep 09 '25 22:09 coderfender

Working on SUM (which setup a base framework in terms of setting ANSI support given that we leverage DF's UDAF functionality

coderfender avatar Oct 15 '25 23:10 coderfender

Given that SUM function 's ANSI implementation is spark specific, I will be moving ahead in implementing a comet native function (with integral support) and probably raise a draft PR by early next week

coderfender avatar Oct 16 '25 22:10 coderfender