datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard

fix: Fall back to Spark for MakeDecimal with unsupported input type

Open andygrove opened this issue 3 weeks ago • 1 comments

Which issue does this PR close?

Closes https://github.com/apache/datafusion-comet/issues/2813

Rationale for this change

What changes are included in this PR?

How are these changes tested?

andygrove avatar Nov 21 '25 23:11 andygrove

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 59.14%. Comparing base (f09f8af) to head (726ca21). :warning: Report is 736 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2815      +/-   ##
============================================
+ Coverage     56.12%   59.14%   +3.02%     
- Complexity      976     1471     +495     
============================================
  Files           119      167      +48     
  Lines         11743    15238    +3495     
  Branches       2251     2514     +263     
============================================
+ Hits           6591     9013    +2422     
- Misses         4012     4942     +930     
- Partials       1140     1283     +143     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Nov 21 '25 23:11 codecov-commenter

are we waiting to address any feedback on this PR?

comphead avatar Dec 08 '25 16:12 comphead

are we waiting to address any feedback on this PR?

I think I addressed all of the feedback from @martin-g

andygrove avatar Dec 10 '25 01:12 andygrove

Thanks @andygrove and @martin-g for the review.

I feel this PR is good as it has the consistent issue before the PR and after PR it is fixed, probably remaining feedback we can address in following PRs if you guys okay with that

Sounds good to me. Thanks @comphead and @martin-g.

andygrove avatar Dec 10 '25 16:12 andygrove