datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard

Minor: Add unit tests for `ceil`/`floor` functions

Open tlm365 opened this issue 6 months ago • 1 comments

Which issue does this PR close?

Closes #.

Rationale for this change

The unit tests for ceil/floor functions is missing

What changes are included in this PR?

Unit tests for ceil/floor functions

How are these changes tested?

CI

tlm365 avatar May 10 '25 04:05 tlm365

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.10%. Comparing base (f09f8af) to head (9e960c6). Report is 289 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1728       +/-   ##
=============================================
- Coverage     56.12%   39.10%   -17.03%     
+ Complexity      976      894       -82     
=============================================
  Files           119      131       +12     
  Lines         11743    12902     +1159     
  Branches       2251     2396      +145     
=============================================
- Hits           6591     5045     -1546     
- Misses         4012     6867     +2855     
+ Partials       1140      990      -150     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar May 10 '25 16:05 codecov-commenter

Thanks for the PR @tlm365. Could I suggest that you mark the tests with ignore and add a link to the issue https://github.com/apache/datafusion-comet/issues/1729 and then we can merge this PR and enable the tests once the bug is fixed?

Also, you need to run make format to fix the formatting.

andygrove avatar Jun 24 '25 17:06 andygrove

Thanks for the PR @tlm365. Could I suggest that you mark the tests with ignore and add a link to the issue #1729 and then we can merge this PR and enable the tests once the bug is fixed?

Also, you need to run make format to fix the formatting.

@andygrove Thanks for reviewing. I’ve updated it.

tlm365 avatar Jun 27 '25 06:06 tlm365