cordova-node-xcode icon indicating copy to clipboard operation
cordova-node-xcode copied to clipboard

Add support for 'alwaysOutOfDate' PBX Shell Script property

Open marco-saia-datadog opened this issue 1 year ago • 4 comments

This PR adds support for the alwaysOutOfDate property in PBX Shell Scripts.

Setting alwaysOutOfDate to true disables dependency analysis for the given build phase, clearing warnings such as:

Script has ambiguous dependencies causing it to run on every build

Since by default the property is not added to the PBX project file by Xcode, I have decided to write it down in the PBX file only if explicitly specified in the pbxShellScriptBuildPhaseObj options, hence the null check.

marco-saia-datadog avatar May 31 '24 10:05 marco-saia-datadog

I think this is a good addition, and one that Cordova itself could probably use. I've enabled the CI tests which obviously requires some chore work since it's still configured to use NodeJS 10 (It's been years since this package had updates!)

I've added a 3.1.0 milestone so that this PR isn't forgotten for when we prepare the next release, though a 4.0.0 already exists so this feature might be added with the next major release instead of a minor release.

Code wise, I think is :+1: just the CI needs to be updated to use modern NodeJS versions and then this PR will need a rebase.

breautek avatar Jun 28 '24 13:06 breautek

Wonderful! Thank you @breautek 😃

marco-saia-datadog avatar Jun 28 '24 16:06 marco-saia-datadog

Hey @marco-saia-datadog

If you could rebase this PR it should fix the CI for you.

breautek avatar Jul 02 '24 12:07 breautek

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.98%. Comparing base (c491d3a) to head (fe105da).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   89.97%   89.98%           
=======================================
  Files           6        6           
  Lines        2374     2376    +2     
=======================================
+ Hits         2136     2138    +2     
  Misses        238      238           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 02 '24 13:07 codecov-commenter