cordova-ios icon indicating copy to clipboard operation
cordova-ios copied to clipboard

fix: Properly set the WebView config when it is provided

Open dpogue opened this issue 1 year ago • 2 comments

Platforms affected

iOS

Motivation and Context

Fixes GH-1423 (based on the comment on https://github.com/apache/cordova-ios/commit/4c8136345ae9622646ee7e4eb60ba2b37ad44fbe#r142043240)

Description

Check that the engine class instance responds to the initWithFrame:configuration: selector rather than the engine class itself (because it's not a static class method).

Testing

All unit tests pass, but I don't think we have test coverage for this particular feature.

Checklist

  • [x] I've run the tests to see all new and existing tests pass
  • [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

dpogue avatar May 27 '24 21:05 dpogue

/fyi @msmtamburro @Durzan666

dpogue avatar May 27 '24 21:05 dpogue

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.35%. Comparing base (2240ebc) to head (93a95e6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1436   +/-   ##
=======================================
  Coverage   78.35%   78.35%           
=======================================
  Files          16       16           
  Lines        1825     1825           
=======================================
  Hits         1430     1430           
  Misses        395      395           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 27 '24 21:05 codecov-commenter