cordova-ios
cordova-ios copied to clipboard
apache
Add CDVWebViewEngineConfigurationDelegate to expose the WKWebViewConfiguration
Platforms affected
iOS
This can be merged after https://github.com/apache/cordova-ios/pull/1051
Motivation and Context
CDVWebViewEngine needs a way to set the websiteDataStore of its configuration.
Fixes: https://github.com/apache/cordova-ios/issues/900
Description
Adds and exposes a protocol, CDVWebViewEngineConfigurationDelegate, which allows access to the configuration.
Testing
Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with
(platform)if this change only applies to one platform (e.g.(android)) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
- [ ] I've updated the documentation if necessary
Codecov Report
Merging #1157 (fb215c8) into master (f804a42) will increase coverage by
78.26%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #1157 +/- ##
===========================================
+ Coverage 0 78.26% +78.26%
===========================================
Files 0 15 +15
Lines 0 1767 +1767
===========================================
+ Hits 0 1383 +1383
- Misses 0 384 +384
| Impacted Files | Coverage Δ | |
|---|---|---|
| lib/versions.js | 89.36% <0.00%> (ø) |
|
| lib/run.js | 21.97% <0.00%> (ø) |
|
| lib/create.js | 95.83% <0.00%> (ø) |
|
| lib/build.js | 63.69% <0.00%> (ø) |
|
| lib/listEmulatorImages.js | 100.00% <0.00%> (ø) |
|
| lib/BridgingHeader.js | 95.45% <0.00%> (ø) |
|
| lib/listEmulatorBuildTargets.js | 96.77% <0.00%> (ø) |
|
| lib/plugman/pluginHandlers.js | 90.05% <0.00%> (ø) |
|
| lib/listDevices.js | 100.00% <0.00%> (ø) |
|
| lib/Api.js | 71.76% <0.00%> (ø) |
|
| ... and 5 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
The CDVWebViewEngineConfigurationDelegate work has already been merged to master, and the extra commits make it quite hard to see what the actual change is here.
Can you rebase so that this includes only the commit related to data storage?
Yes! Just lost my access to push changes from work, so it may be a while.
@msmtamburro was this pull request final? Still marked as Draft? Is this pull request fully working ?
Sorry it took so long to get back to you on this, but good news: nothing to do here. The commits in this PR safely made it to master in an earlier PR. I'll close this, and the associated issue.