cordova-browser
cordova-browser copied to clipboard
GH-122 browser: permit serving over https
Platforms affected
Browser
Motivation and Context
Closes #122.
Description
This PR adds a new boolean option --https which will serve the browser platform over HTTPS.
These issues is other Cordova repos are also required:
- https://github.com/apache/cordova-serve/issues/55
- https://github.com/apache/cordova-cli/issues/621
Testing
A test for cordova run browser seems not to be present in this repo (?).
Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with
(platform)if this change only applies to one platform (e.g.(android)) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
- [x] I've updated the documentation if necessary
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 93.75%. Comparing base (66d9e2e) to head (857821c).
:warning: Report is 9 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 2 2
Lines 32 32
=======================================
Hits 30 30
Misses 2 2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.