commons-dbutils icon indicating copy to clipboard operation
commons-dbutils copied to clipboard

Update BeanProcessor.java

Open rractg opened this issue 1 year ago • 2 comments
trafficstars

Use classloadercontext in serviceloader. This allows for correct usage when calling this library from within a isolated ClassLoader. A similar change was done in slf4j : https://github.com/qos-ch/slf4j/commit/43a36303e5a2338c22ec9aad5b01a401034eb553

rractg avatar Mar 20 '24 14:03 rractg

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 62.68%. Comparing base (2ab67d2) to head (669ecd2). :warning: Report is 304 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
+ Coverage     62.61%   62.68%   +0.07%     
- Complexity      412      413       +1     
============================================
  Files            39       39              
  Lines          1383     1383              
  Branches        104      104              
============================================
+ Hits            866      867       +1     
+ Misses          468      467       -1     
  Partials         49       49              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Mar 21 '24 01:03 codecov-commenter

Is there a test you can write to check if this change does anything where changing the main code back would cause it to fail? Otherwise, this is a regression waiting to happen 😞

garydgregory avatar Mar 21 '24 01:03 garydgregory