cloudstack
cloudstack copied to clipboard
apache
Added update, enable, disable events to the updateStoragePool API
Description
This PR addresses the issue #8494
Fixes the issue of missing Enable, Disable action events when trying to do that using updateStoragePool. Also added new Action event UPDATE.PS to the actual update storage pool event.
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 4.16%. Comparing base (
2ba64f2) to head (fe0a3bd). Report is 75 commits behind head on main.
:exclamation: There is a different number of reports uploaded between BASE (2ba64f2) and HEAD (fe0a3bd). Click for more details.
HEAD has 1 upload less than BASE
Flag BASE (2ba64f2) HEAD (fe0a3bd) unittests 1 0
Additional details and impacted files
@@ Coverage Diff @@
## main #9543 +/- ##
============================================
- Coverage 15.54% 4.16% -11.38%
============================================
Files 5499 377 -5122
Lines 481706 30889 -450817
Branches 58660 5466 -53194
============================================
- Hits 74879 1288 -73591
+ Misses 398541 29455 -369086
+ Partials 8286 146 -8140
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 4.16% <ø> (-0.01%) |
:arrow_down: |
| unittests | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10695
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10721
@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-11123) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 57312 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9543-t11123-kvm-ol8.zip Smoke tests completed. 135 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_DeployVmAffinityGroup | Error |
1.42 | test_affinity_groups.py |
| test_01_non_strict_host_anti_affinity | Error |
3.71 | test_nonstrict_affinity_group.py |
| test_02_non_strict_host_affinity | Error |
3.61 | test_nonstrict_affinity_group.py |
| test_01_secure_vm_migration | Error |
402.58 | test_vm_life_cycle.py |
| test_13_migrate_volume_and_change_offering | Error |
121.12 | test_volumes.py |
test_13_migrate_volume_and_change_offering failure is because of this PR change, will update the PR accordingly.
cc @DaanHoogland
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10770
@harikrishna-patnala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-11154) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 53649 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9543-t11154-kvm-ol8.zip Smoke tests completed. 138 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_04_deploy_vnf_appliance | Error |
103.03 | test_vnf_templates.py |
| test_04_deploy_vnf_appliance | Error |
103.03 | test_vnf_templates.py |
| test_05_delete_vnf_template | Error |
1.10 | test_vnf_templates.py |
| ContextSuite context=TestVnfTemplates>:teardown | Error |
2.24 | test_vnf_templates.py |
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-11180) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 50425 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9543-t11180-kvm-ol8.zip Smoke tests completed. 139 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10838
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10839
@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-11324) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 54960 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9543-t11324-kvm-ol8.zip Smoke tests completed. 138 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_02_redundant_VPC_default_routes | Failure |
395.88 | test_vpc_redundant.py |
| test_05_rvpc_multi_tiers | Failure |
488.42 | test_vpc_redundant.py |
| test_05_rvpc_multi_tiers | Error |
488.44 | test_vpc_redundant.py |