NSX Integration fixes

[Pearl1594]

Description

This PR addresses issues identified in https://github.com/apache/cloudstack/pull/7919

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] Enhancement (improves an existing feature and functionality)
• [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
• [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [ ] Minor

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [ ] Minor
• [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 22.16749% with 158 lines in your changes missing coverage. Please review.

Project coverage is 15.76%. Comparing base (f683d2d) to head (d1a6038). Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
...va/org/apache/cloudstack/service/NsxApiClient.java	11.86%	50 Missing and 2 partials :warning:
...java/org/apache/cloudstack/service/NsxElement.java	47.69%	24 Missing and 10 partials :warning:
...va/org/apache/cloudstack/resource/NsxResource.java	11.11%	14 Missing and 2 partials :warning:
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java	0.00%	15 Missing :warning:
...KubernetesClusterResourceModifierActionWorker.java	0.00%	10 Missing :warning:
.../org/apache/cloudstack/service/NsxServiceImpl.java	11.11%	8 Missing :warning:
...src/main/java/org/apache/cloudstack/NsxAnswer.java	0.00%	6 Missing :warning:
...cloudstack/affinity/HostAntiAffinityProcessor.java	0.00%	4 Missing :warning:
...loudstack/resourcedetail/FirewallRuleDetailVO.java	0.00%	3 Missing :warning:
...che/cloudstack/affinity/HostAffinityProcessor.java	25.00%	2 Missing and 1 partial :warning:
... and 6 more

Additional details and impacted files

@@             Coverage Diff             @@
##               main    #8906     +/-   ##
===========================================
  Coverage     15.76%   15.76%             
  Complexity    12507    12507             
===========================================
  Files          5619     5620      +1     
  Lines        491156   491268    +112     
  Branches      60118    62845   +2727     
===========================================
+ Hits          77418    77437     +19     
- Misses       405282   405369     +87     
- Partials       8456     8462      +6     

Flag	Coverage Δ
uitests	4.05% <ø> (ø)
unittests	16.57% <22.16%> (+<0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 9237

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9238

[nvazquez]

@blueorangutan test matrix

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9820) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42335 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8906-t9820-kvm-centos7.zip Smoke tests completed. 122 look OK, 7 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	299.84	test_events_resource.py
test_01_events_resource	Error	299.85	test_events_resource.py
test_DeployVmAntiAffinityGroup_in_project	Error	88.96	test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup	Error	37.64	test_affinity_groups.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	26.81	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	0.06	test_kubernetes_clusters.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	Failure	82.31	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	Error	1.33	test_network_permissions.py
test_01_non_strict_host_anti_affinity	Failure	123.30	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	Error	81.26	test_nonstrict_affinity_group.py
test_hostha_enable_ha_when_host_in_maintenance	Error	305.87	test_hostha_kvm.py

[blueorangutan]

[SF] Trillian test result (tid-9818) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45078 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8906-t9818-xenserver-71.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	223.19	test_events_resource.py
test_01_events_resource	Error	223.20	test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	Failure	108.97	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	Error	1.41	test_network_permissions.py

[blueorangutan]

[SF] Trillian test result (tid-9819) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 60880 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8906-t9819-vmware-67u3.zip Smoke tests completed. 126 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	204.07	test_events_resource.py
test_01_events_resource	Error	204.07	test_events_resource.py
test_list_vms_metrics_admin	Error	3621.84	test_metrics_api.py
test_list_vms_metrics_history	Error	4.70	test_metrics_api.py
test_list_volumes_metrics_history	Error	3618.82	test_metrics_api.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	Failure	99.17	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	Error	1.46	test_network_permissions.py

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9800

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9801

[github-actions[bot]]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10665

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10667

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10670

[Pearl1594]

@blueorangutan test matrix

[blueorangutan]

@Pearl1594 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests