cloudberry icon indicating copy to clipboard operation
cloudberry copied to clipboard

Cherry-pick ORCA InPlaceUpdate implementation

Open foreyes opened this issue 1 year ago • 1 comments

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • [ ] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • [ ] Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • [ ] Learn the coding contribution guide, including our code conventions, workflow and more.
  • [ ] List your communication in the GitHub Issues or Discussions (if has or needed).
  • [ ] Document changes.
  • [ ] Add tests for the change
  • [ ] Pass make installcheck
  • [ ] Pass make -C src/test installcheck-cbdb-parallel
  • [ ] Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

foreyes avatar Aug 28 '24 06:08 foreyes

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 7 committers have signed the CLA.

:white_check_mark: foreyes
:x: l-wang
:x: THANATOSLAVA
:x: khannaekta
:x: dgkimura
:x: Sanath97
:x: pobbatihari
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 28 '24 06:08 CLAassistant

@foreyes address the conflicts and make CI pass pls.

without conflicts address, the CI won't running.

jiaqizho avatar Oct 09 '24 01:10 jiaqizho

@foreyes address the conflicts and make CI pass pls.

without conflicts address, the CI won't running.

@jiaqizho CI already passed, please continue to review.

my-ship-it avatar Oct 16 '24 16:10 my-ship-it

@foreyes any updated?

jiaqizho avatar Oct 30 '24 09:10 jiaqizho

@jiaqizho @leborchuk This MR was not updated because it caused some testing failures in our internal repository, and I am still trying to find out the reason behind it. But now there is no problem merging into the GitHub repository, and this MR only cherry picked some of the GreenPlum modifications and resolved conflicts. Maybe I can figure out the internal repo CI failure later.

Only ORCA SplitUpdate and the submissions it depends on are selected.

foreyes avatar Oct 31 '24 03:10 foreyes

I'll resolve the conflict and update this MR soon.

foreyes avatar Oct 31 '24 03:10 foreyes

@jiaqizho commit message updated and CI passed.

foreyes avatar Nov 01 '24 00:11 foreyes