beam icon indicating copy to clipboard operation
beam copied to clipboard

Add WindowedValueParam option to DoFns.

Open robertwb opened this issue 1 year ago • 3 comments

This is useful when one wants to capture and preserve all the windowing information for later use (and is both more convenient and less error-prone than gathering the timestamp, windows, and pane info separately).

New values with the same windowing value can be constructed via WindowedValue.with_value(...) and emitted asynchronously (e.g. after batching or in finish_bundle).


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

robertwb avatar Aug 23 '24 22:08 robertwb

R: @ganesh4991

robertwb avatar Aug 23 '24 22:08 robertwb

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

github-actions[bot] avatar Aug 23 '24 22:08 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.81%. Comparing base (e62daf7) to head (9771a42). Report is 49 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #32305   +/-   ##
=========================================
  Coverage     58.81%   58.81%           
  Complexity     3023     3023           
=========================================
  Files          1123     1123           
  Lines        173452   173459    +7     
  Branches       3301     3301           
=========================================
+ Hits         102021   102026    +5     
- Misses        68099    68101    +2     
  Partials       3332     3332           
Flag Coverage Δ
python 81.62% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 23 '24 23:08 codecov[bot]