beam icon indicating copy to clipboard operation
beam copied to clipboard

Avoid length-prefix-bytes substitutions for Flink boundaries.

Open robertwb opened this issue 1 year ago • 3 comments

The runner infrastructure typically substitutes "unknown" coders for length-prefixed bytes, but for elements going into or out of the Beam pipeline fragment we want the actual objects. Fortunately, we know these coders are known on the Runner side as well as the SDK side as we have them in hand there.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

robertwb avatar Jun 12 '24 21:06 robertwb

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Jun 12 '24 22:06 github-actions[bot]

Ready for review ?

chamikaramj avatar Jun 24 '24 18:06 chamikaramj

Yes, this is ready for review. Would you be willing to take a look.

robertwb avatar Jun 24 '24 18:06 robertwb

R: @kennknowles

robertwb avatar Jul 08 '24 23:07 robertwb

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar Jul 08 '24 23:07 github-actions[bot]