beam icon indicating copy to clipboard operation
beam copied to clipboard

Add a test for sql dialect.

Open robertwb opened this issue 1 year ago • 1 comments


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

robertwb avatar May 13 '24 19:05 robertwb

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.42%. Comparing base (93cc6a5) to head (f54fda9). Report is 25 commits behind head on master.

:exclamation: Current head f54fda9 differs from pull request most recent head 59b0fdc

Please upload reports for the commit 59b0fdc to get more accurate results.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #31276       +/-   ##
=============================================
+ Coverage     68.55%   71.42%    +2.87%     
+ Complexity    14921     1474    -13447     
=============================================
  Files          2636      909     -1727     
  Lines        222073   113707   -108366     
  Branches      11825     1076    -10749     
=============================================
- Hits         152234    81214    -71020     
+ Misses        63644    30474    -33170     
+ Partials       6195     2019     -4176     
Flag Coverage Δ
python 81.41% <ø> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 13 '24 20:05 codecov[bot]

R: @shunping

robertwb avatar May 28 '24 18:05 robertwb

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar May 28 '24 18:05 github-actions[bot]

Ping?

robertwb avatar Jun 03 '24 15:06 robertwb

LGTM. Thanks!

shunping avatar Jun 03 '24 16:06 shunping