beam
beam copied to clipboard
Add a workaround for BEAM-20873 for optimized list side inputs.
This triggered a case with Dataflow Runner v1 and PTransformOverrides that exposed https://github.com/apache/beam/issues/20873 .
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead. - [ ] Update
CHANGES.mdwith noteworthy changes. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.
R: @abacn
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
Looks like cacheCandidatesUpdaterTest (org.apache.beam.runners.spark.CacheTest) failed in 2 attempts.
THe failing test is caused by this PR. After merged java precommit is red on master branch, and the same failure see in other PRs (e.g. #31175: https://github.com/apache/beam/actions/runs/8943529889/job/24568447748?pr=31175)
I checked locally that it fails on latest master
cacheCandidatesUpdaterTest
java.lang.AssertionError: expected:<2> but was:<3>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
and passes when reverting this PR
$ git checkout HEAD^
$ ./gradlew :runners:spark:3:test --tests org.apache.beam.runners.spark.CacheTest
get
Tests Standard error
Test Duration Result
cacheCandidatesUpdaterTest 0.333s passed
shouldCacheTest 1.137s passed
Does anyone know what this test is trying to verify? It does look related, but it also looks like it might be a change detector test.
https://github.com/apache/beam/pull/31184