beam icon indicating copy to clipboard operation
beam copied to clipboard

Pass getattr calls in AbstractDoFnWrapper to the wrapped dofn for stateful dofns.

Open jonathanasdf opened this issue 3 years ago • 3 comments

Otherwise there is an error

  File "/private/tmp/beam/sdks/python/apache_beam/transforms/userstate.py", line 304, in validate_stateful_dofn
    if (timer_spec._attached_callback != getattr(dofn, method_name,
AttributeError: 'NoneType' object has no attribute '__func__'

R: @charlesccychen

  • [x] Choose reviewer(s) and mention them in a comment (R: @username).
  • [x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [x] Update CHANGES.md with noteworthy changes.
  • [x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI.

jonathanasdf avatar Aug 01 '22 19:08 jonathanasdf

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Aug 01 '22 20:08 github-actions[bot]

R: @charlesccychen

jonathanasdf avatar Aug 05 '22 21:08 jonathanasdf

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar Aug 05 '22 21:08 github-actions[bot]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Oct 05 '22 12:10 github-actions[bot]

bump

jonathanasdf avatar Oct 05 '22 20:10 jonathanasdf

I will go ahead and review this. I suspect the reviewer you tagged is not active in Beam

AnandInguva avatar Oct 05 '22 21:10 AnandInguva

Thanks, it was the only choice from https://github.com/apache/beam/blob/master/sdks/python/apache_beam/typehints/OWNERS maybe that should be updated.

jonathanasdf avatar Oct 05 '22 21:10 jonathanasdf

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Jan 03 '23 12:01 github-actions[bot]

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Jan 21 '23 12:01 github-actions[bot]

@jonathanasdf Hi sorry, This was slipped from my plate. Is this still relevant?

AnandInguva avatar Jan 21 '23 15:01 AnandInguva