beam
beam copied to clipboard
Pass getattr calls in AbstractDoFnWrapper to the wrapped dofn for stateful dofns.
Otherwise there is an error
File "/private/tmp/beam/sdks/python/apache_beam/transforms/userstate.py", line 304, in validate_stateful_dofn
if (timer_spec._attached_callback != getattr(dofn, method_name,
AttributeError: 'NoneType' object has no attribute '__func__'
R: @charlesccychen
- [x] Choose reviewer(s) and mention them in a comment (
R: @username). - [x] Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead. - [x] Update
CHANGES.mdwith noteworthy changes. - [x] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.
Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:
R: @AnandInguva for label python.
Available commands:
stop reviewer notifications- opt out of the automated review toolingremind me after tests pass- tag the comment author after tests passwaiting on author- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
R: @charlesccychen
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
bump
I will go ahead and review this. I suspect the reviewer you tagged is not active in Beam
Thanks, it was the only choice from https://github.com/apache/beam/blob/master/sdks/python/apache_beam/typehints/OWNERS maybe that should be updated.
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
@jonathanasdf Hi sorry, This was slipped from my plate. Is this still relevant?