beam icon indicating copy to clipboard operation
beam copied to clipboard

sklearn runinference regression example

Open ryanthompson591 opened this issue 3 years ago • 23 comments

This is an example of a regression model using an sklearn pipeline.

This illustrates how to separate examples based on what features are available in the example and then using an sklearn pipeline made for that data.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Choose reviewer(s) and mention them in a comment (R: @username).
  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests

See CI.md for more information about GitHub Actions CI.

ryanthompson591 avatar Jun 28 '22 22:06 ryanthompson591

Can one of the admins verify this patch?

asf-ci avatar Jun 28 '22 22:06 asf-ci

Can one of the admins verify this patch?

asf-ci avatar Jun 28 '22 22:06 asf-ci

Can one of the admins verify this patch?

asf-ci avatar Jun 28 '22 22:06 asf-ci

Can one of the admins verify this patch?

asf-ci avatar Jun 28 '22 22:06 asf-ci

Can one of the admins verify this patch?

asf-ci avatar Jun 28 '22 22:06 asf-ci

R: @AnandInguva

ryanthompson591 avatar Jun 28 '22 22:06 ryanthompson591

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar Jun 28 '22 22:06 github-actions[bot]

Codecov Report

Merging #22088 (12c24f1) into master (48513ad) will decrease coverage by 0.14%. The diff coverage is 34.48%.

@@            Coverage Diff             @@
##           master   #22088      +/-   ##
==========================================
- Coverage   74.18%   74.03%   -0.15%     
==========================================
  Files         706      706              
  Lines       93229    93428     +199     
==========================================
+ Hits        69159    69168       +9     
- Misses      22802    22994     +192     
+ Partials     1268     1266       -2     
Flag Coverage Δ
python 83.55% <34.48%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/inference/sklearn_japanese_housing_regression.py 34.48% <34.48%> (ø)
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) :arrow_down:
sdks/go/pkg/beam/io/filesystem/memfs/memory.go 92.00% <0.00%> (-4.16%) :arrow_down:
.../apache_beam/runners/interactive/dataproc/types.py 93.10% <0.00%> (-3.45%) :arrow_down:
...che_beam/runners/interactive/interactive_runner.py 90.06% <0.00%> (-1.33%) :arrow_down:
...ks/go/pkg/beam/runners/dataflow/dataflowlib/job.go 21.55% <0.00%> (-1.13%) :arrow_down:
sdks/python/apache_beam/internal/metrics/metric.py 93.00% <0.00%> (-1.00%) :arrow_down:
sdks/go/pkg/beam/core/runtime/exec/input.go 50.96% <0.00%> (-1.00%) :arrow_down:
...hon/apache_beam/runners/direct/test_stream_impl.py 93.28% <0.00%> (-0.75%) :arrow_down:
sdks/python/apache_beam/io/fileio.py 95.98% <0.00%> (-0.28%) :arrow_down:
... and 34 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jun 28 '22 23:06 codecov[bot]

R: @tvalentyn

ryanthompson591 avatar Jun 30 '22 17:06 ryanthompson591

Run Python 3.8 PostCommit

ryanthompson591 avatar Jul 14 '22 15:07 ryanthompson591

Run Python 3.7 PostCommit

AnandInguva avatar Jul 14 '22 15:07 AnandInguva

The inference tests will run on lowest and highest python versions. Python 37 and 39 as of now

AnandInguva avatar Jul 14 '22 15:07 AnandInguva

Run Python 3.7 PostCommit

ryanthompson591 avatar Jul 15 '22 19:07 ryanthompson591

Run Python 3.7 PostCommit

ryanthompson591 avatar Aug 02 '22 15:08 ryanthompson591

Run Python 3.7 PostCommit

ryanthompson591 avatar Aug 03 '22 14:08 ryanthompson591

Let me know when this is ready to review/merge.

tvalentyn avatar Aug 03 '22 21:08 tvalentyn

Run Python 3.9 PostCommit

ryanthompson591 avatar Aug 04 '22 17:08 ryanthompson591

Run Python 3.9 PostCommit

ryanthompson591 avatar Aug 05 '22 14:08 ryanthompson591

Run Python 3.7 PostCommit

ryanthompson591 avatar Aug 05 '22 14:08 ryanthompson591

Run Python 3.9 PostCommit

ryanthompson591 avatar Aug 05 '22 14:08 ryanthompson591

@tvalentyn This looks ready to merge, the failing test is not the new test I added but rather the issue described here: https://github.com/apache/beam/issues/22605

ryanthompson591 avatar Aug 08 '22 18:08 ryanthompson591

Run Python 3.9 PostCommit

ryanthompson591 avatar Aug 08 '22 18:08 ryanthompson591

Run Python 3.9 PostCommit

ryanthompson591 avatar Aug 09 '22 14:08 ryanthompson591

Run Python 3.9 PostCommit

tvalentyn avatar Aug 16 '22 22:08 tvalentyn