arrow icon indicating copy to clipboard operation
arrow copied to clipboard

GH-40077: [CI] Use GitHub hosted M1 macOS runner

Open kou opened this issue 1 year ago • 34 comments
trafficstars

Rationale for this change

If we use GitHub hosted M1 macOS runner instead of self-hosted M1 macOS runner, we don't need to maintain self-hosted M1 macOS runner.

What changes are included in this PR?

Use GitHub hosted M1 macOS runner except r-binary-packages's r-packages job. It uses macOS 11 but GitHub hosted M1 macOS runner is 13 or 14.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

  • GitHub Issue: #40077

kou avatar Mar 09 '24 22:03 kou

:warning: GitHub issue #40077 has been automatically assigned in GitHub to PR creator.

github-actions[bot] avatar Mar 09 '24 22:03 github-actions[bot]

@github-actions crossbow submit java-jars wheel-macos-*-arm64 r-binary-packages

kou avatar Mar 09 '24 22:03 kou

@github-actions crossbow submit verify-rc-source-*-macos-arm64

kou avatar Mar 09 '24 22:03 kou

Revision: 9402b086fcdd4f869cdd9105c79dacc447a5fabf

Submitted crossbow builds: ursacomputing/crossbow @ actions-ea0c6b13a7

Task Status
java-jars GitHub Actions
r-binary-packages GitHub Actions
wheel-macos-big-sur-cp310-arm64 GitHub Actions
wheel-macos-big-sur-cp311-arm64 GitHub Actions
wheel-macos-big-sur-cp312-arm64 GitHub Actions
wheel-macos-big-sur-cp38-arm64 GitHub Actions
wheel-macos-big-sur-cp39-arm64 GitHub Actions

github-actions[bot] avatar Mar 09 '24 22:03 github-actions[bot]

Can we use macos-13-arm64 or macos-14-arm64 to verify RC of wheels?

https://github.com/apache/arrow/blob/6a7a6ee308b69c12f46f874cb3d52892e172d7b7/dev/tasks/tasks.yml#L1007-L1014

Is macos-11 important here?

kou avatar Mar 09 '24 22:03 kou

Revision: 9402b086fcdd4f869cdd9105c79dacc447a5fabf

Submitted crossbow builds: ursacomputing/crossbow @ actions-a125f3ca79

Task Status
verify-rc-source-cpp-macos-arm64 GitHub Actions
verify-rc-source-csharp-macos-arm64 GitHub Actions
verify-rc-source-go-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-arm64 GitHub Actions
verify-rc-source-js-macos-arm64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions
verify-rc-source-ruby-macos-arm64 GitHub Actions

github-actions[bot] avatar Mar 09 '24 22:03 github-actions[bot]

@github-actions crossbow submit java-jars wheel-macos--arm64 r-binary-packages verify-rc-source--macos-arm64

kou avatar Mar 10 '24 03:03 kou

Revision: ff1916944d5649d526925e2e7264bd123b95d7c3

Submitted crossbow builds: ursacomputing/crossbow @ actions-5f14f4029e

Task Status
java-jars GitHub Actions
r-binary-packages GitHub Actions
verify-rc-source-cpp-macos-arm64 GitHub Actions
verify-rc-source-csharp-macos-arm64 GitHub Actions
verify-rc-source-go-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-arm64 GitHub Actions
verify-rc-source-js-macos-arm64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions
verify-rc-source-ruby-macos-arm64 GitHub Actions
wheel-macos-big-sur-cp310-arm64 GitHub Actions
wheel-macos-big-sur-cp311-arm64 GitHub Actions
wheel-macos-big-sur-cp312-arm64 GitHub Actions
wheel-macos-big-sur-cp38-arm64 GitHub Actions
wheel-macos-big-sur-cp39-arm64 GitHub Actions

github-actions[bot] avatar Mar 10 '24 03:03 github-actions[bot]

Imo I think we can drop the self hosted M1 for r-binary-packages as well, then we can retire the runner completely. It don't recall ever having an issue with the package related to the macos version (and x86 is even run on macos 13). The issues are usually with the environment setup (e.g. gnu libtool being on the path etc.)

assignUser avatar Mar 10 '24 04:03 assignUser

OK. Let's try with GitHub hosted runner.

kou avatar Mar 10 '24 04:03 kou

@github-actions crossbow submit java-jars wheel-macos-big-sur-cp310-arm64 r-binary-packages verify-rc-source-cpp-macos-arm64

kou avatar Mar 10 '24 05:03 kou

Revision: 839cd6937e4ebe308ef01a5ebafc8f217031626e

Submitted crossbow builds: ursacomputing/crossbow @ actions-9f8a35ae2c

Task Status
java-jars GitHub Actions
r-binary-packages GitHub Actions
verify-rc-source-cpp-macos-arm64 GitHub Actions
wheel-macos-big-sur-cp310-arm64 GitHub Actions

github-actions[bot] avatar Mar 10 '24 05:03 github-actions[bot]

@github-actions crossbow submit wheel-macos-big-sur-cp310-* r-binary-packages

kou avatar Mar 10 '24 05:03 kou

while constructing a mapping
  in "<unicode string>", line 187, column 3:
      conan-minimum:
      ^ (line: 187)
found duplicate key "wheel-macos-big-sur-cp38-arm64" with value "{'ci': 'github', 'template': 'python-wheels/github.osx.yml', 'params': {'arch': 'arm64', 'arrow_jemalloc': 'OFF', 'python_version': '3.8', 'macos_deployment_target': '11.0', 'runs_on': 'macos-14', 'vcpkg_arch': 'arm64'}, 'artifacts': ['pyarrow-{no_rc_version}-cp38-cp38-macosx_11_0_arm64.whl']}" (original value: "{'ci': 'github', 'template': 'python-wheels/github.osx.yml', 'params': {'arch': 'arm64', 'arrow_jemalloc': 'OFF', 'python_version': '3.8', 'macos_deployment_target': '11.0', 'runs_on': 'macos-14', 'vcpkg_arch': 'arm64'}, 'artifacts': ['pyarrow-{no_rc_version}-cp38-cp38-macosx_11_0_arm64.whl']}")
  in "<unicode string>", line 569, column 3:
      wheel-macos-big-sur-cp38-arm64:
      ^ (line: 569)

To suppress this check see:
    http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys

The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/8219946313

github-actions[bot] avatar Mar 10 '24 05:03 github-actions[bot]

@github-actions crossbow submit wheel-macos-big-sur-cp310-* r-binary-packages

kou avatar Mar 10 '24 06:03 kou

Revision: 0d1cd164b40d293a782b7cee23dfc6a3314d94b5

Submitted crossbow builds: ursacomputing/crossbow @ actions-6d43ed56d0

Task Status
r-binary-packages GitHub Actions
wheel-macos-big-sur-cp310-arm64 GitHub Actions

github-actions[bot] avatar Mar 10 '24 06:03 github-actions[bot]

@github-actions crossbow submit wheel-macos--cp310-

kou avatar Mar 10 '24 06:03 kou

Revision: e23aa6185c06c084ca06239f71cba047c4bafc00

Submitted crossbow builds: ursacomputing/crossbow @ actions-076fef4716

Task Status
wheel-macos-big-sur-cp310-arm64 GitHub Actions
wheel-macos-catalina-cp310-amd64 GitHub Actions

github-actions[bot] avatar Mar 10 '24 06:03 github-actions[bot]

@github-actions crossbow submit wheel-macos--cp310-

kou avatar Mar 10 '24 06:03 kou

Revision: 7d9ecc548d84e96c86bf0e910eb958c63b250884

Submitted crossbow builds: ursacomputing/crossbow @ actions-a679ad8157

Task Status
wheel-macos-big-sur-cp310-arm64 GitHub Actions
wheel-macos-catalina-cp310-amd64 GitHub Actions

github-actions[bot] avatar Mar 10 '24 06:03 github-actions[bot]

@github-actions crossbow submit wheel-macos--cp310-

kou avatar Mar 10 '24 07:03 kou

@assignUser Could you check the artifacts of https://github.com/ursacomputing/crossbow/actions/runs/8220036683 ? It uses GitHub hosted runners.

kou avatar Mar 10 '24 07:03 kou

Revision: 3d4b0055f32e07719797979da9b4621da7d62c7f

Submitted crossbow builds: ursacomputing/crossbow @ actions-730eaba0db

Task Status
wheel-macos-big-sur-cp310-arm64 GitHub Actions
wheel-macos-catalina-cp310-amd64 GitHub Actions

github-actions[bot] avatar Mar 10 '24 07:03 github-actions[bot]

@github-actions crossbow submit wheel-macos--cp310-

kou avatar Mar 10 '24 07:03 kou

Revision: ca791120cb6f831b3f078c649700ab6f51f02cf4

Submitted crossbow builds: ursacomputing/crossbow @ actions-c72c57d923

Task Status
wheel-macos-big-sur-cp310-arm64 GitHub Actions
wheel-macos-catalina-cp310-amd64 GitHub Actions

github-actions[bot] avatar Mar 10 '24 07:03 github-actions[bot]

Could we also add a PR C++ job on macOS ARM64? (or perhaps as a separate PR)

pitrou avatar Mar 10 '24 10:03 pitrou

Sure. We should do it in a separated PR because we have a separated issue for it.

kou avatar Mar 10 '24 13:03 kou

Hmm. It seems that we need #40418 for the wheel failures.

kou avatar Mar 10 '24 13:03 kou

@github-actions crossbow submit wheel-macos--cp38-

kou avatar Mar 10 '24 13:03 kou

Revision: a9db9da71dd94785eaa01fffbe7a0c2ec045f996

Submitted crossbow builds: ursacomputing/crossbow @ actions-d07c449d1f

Task Status
wheel-macos-big-sur-cp38-arm64 GitHub Actions
wheel-macos-catalina-cp38-amd64 GitHub Actions

github-actions[bot] avatar Mar 10 '24 13:03 github-actions[bot]