ARROW-17769: [Java] Upgrade adapter/ to Junit 5

[andreoss]

Remove usage of junit-4 from adapter submodules See: ARROW-17769

[github-actions[bot]]

https://issues.apache.org/jira/browse/ARROW-17769

[github-actions[bot]]

:warning: Ticket has not been started in JIRA, please click 'Start Progress'.

[lidavidm]

Filed ARROW-17785 for one CI error (unrelated to this), but it seems the Avro test failures are real? https://github.com/apache/arrow/actions/runs/3079245648/jobs/5000258273#step:5:11465

[andreoss]

@lidavidm Looks like it's an issue with Junit 5 itself. I've disabled these tests for Win. https://github.com/junit-team/junit5/issues/2811

[lidavidm]

I don't see any changes related to that, though disabling tests on Windows is not great - is there any workaround? Maybe an @AfterEach annotation to clear the temporary directory explicitly?

[andreoss]

@lidavidm Please take a look again, the work around here is not to use @TempDir at all

[lidavidm]

@github-actions crossbow submit java

[github-actions[bot]]

Revision: de43d3bf4eb791ab54b79e2f1c3e904cc9a99a82

Submitted crossbow builds: ursacomputing/crossbow @ actions-38656caeeb

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-18.04-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

[lidavidm]

Thanks @andreoss, do you mind rebasing to see if we can get past these CI things?

[lidavidm]

Hmm, the CI failures definitely seem to be related to this PR, but I can't quite figure out how…

[lidavidm]

Ah, thanks @raulcd for helping. It seems the temp directory is not actually cleaned up, and then the Github cache action blows up when it encounters the temp directory (which has different permissions due to the tests running under Docker)

##[debug]/home/runner/work/arrow/arrow/java/adapter/avro/target/avro10505633393856312954
##[debug]Skip directory '/home/runner/work/arrow/arrow/java/adapter/avro/target/avro10505633393856312954'.
##[debug][Error: EACCES: permission denied, scandir '/home/runner/work/arrow/arrow/java/adapter/avro/target/avro10505633393856312954'] {
##[debug]  errno: -13,
##[debug]  code: 'EACCES',
##[debug]  syscall: 'scandir',
##[debug]  path: '/home/runner/work/arrow/arrow/java/adapter/avro/target/avro10505633393856312954'
##[debug]}
##[debug]STDOUT/STDERR stream read finished.
##[debug]STDOUT/STDERR stream read finished.
##[debug]Finished process 4991 with exit code 1, and elapsed time 00:00:00.1356616.

I'm guessing we do have to actually delete the contents of the temp dir, before deleting the directory itself…

[lidavidm]

Hmm, the hashFiles issue is still there - so there's still temp files being left behind

[amol-]

Closing because it has been untouched for a while, in case it's still relevant feel free to reopen and move it forward 👍