arrow
arrow copied to clipboard
ARROW-17175: [CI][macOS] macos-10.15 is deprecated and macos-latest is macos-11
https://github.com/actions/virtual-environments#available-environments
macOS 11 macos-latest or macos-11 macOS 10.15 deprecated macos-10.15
https://issues.apache.org/jira/browse/ARROW-17175
:warning: Ticket has not been started in JIRA, please click 'Start Progress'.
@github-actions crossbow submit homebrew-* wheel-macos-*
Revision: 798b54ef4364226b7e08456e124171dbcaf950dd
Submitted crossbow builds: ursacomputing/crossbow @ actions-e0531f4869
@github-actions crossbow submit homebrew-*
Revision: 63f4ad885d66f74556b761704ffcd6af4baddb13
Submitted crossbow builds: ursacomputing/crossbow @ actions-9751fb9f1c
| Task | Status |
|---|---|
| homebrew-cpp | |
| homebrew-cpp-autobrew | |
| homebrew-r-autobrew | |
| homebrew-r-brew |
Some of our github action builds for macos 10.15 have been failing today as per the deprecation schedule on this issue: https://github.com/actions/virtual-environments/issues/5583
As per this comment https://github.com/actions/virtual-environments/issues/5583#issuecomment-1134941811 macos-latest will be macos 12 after the transition.
Also will this change be an issue for the wheel builds? I know we set 10.15 as the deployment target anyway but afaik it would still be better to test on 10.15? There was some discussion about this in regards to the self-hosted runners in crossbow @pitrou @jorisvandenbossche
@jeroen @nealrichardson Should we keep CI jobs for https://github.com/autobrew/homebrew-core/blob/high-sierra/Formula/apache-arrow.rb ? It's for https://github.com/autobrew/brew not https://github.com/Homebrew/brew but we use https://github.com/Homebrew/brew to test https://github.com/apache/arrow/blob/master/dev/tasks/homebrew-formulae/autobrew/apache-arrow.rb .
FYI: https://github.com/Homebrew/brew removed cellar in bottle block ( https://github.com/Homebrew/brew/commit/f65d525693a45c8e4c2ebc1452080f08c363ee15 ) but https://github.com/autobrew/homebrew-core/blob/high-sierra/Formula/apache-arrow.rb and https://github.com/apache/arrow/blob/master/dev/tasks/homebrew-formulae/autobrew/apache-arrow.rb still use cellar because they are for https://github.com/autobrew/brew not https://github.com/Homebrew/brew .
If we need to keep CI jobs for https://github.com/autobrew/homebrew-core/blob/high-sierra/Formula/apache-arrow.rb, we need to replace Homebrew installed in the macos-latest GitHub Actions runner with https://github.com/autobrew/brew . (I don't know how to do it.)
It seems that https://github.com/autobrew/homebrew-cran is based on https://github.com/Homebrew/brew . Can we remove CI jobs for https://github.com/autobrew/homebrew-core/blob/high-sierra/Formula/apache-arrow.rb and add new CI jobs for https://github.com/autobrew/homebrew-cran/blob/master/Formula/apache-arrow-static.rb (as a follow-up task)?
Autobrew is maintained by Jeroen Ooms and is necessary for the R package due to CRAN targeting EOL macos versions (see here). So removing the autobrew formula is not an option. I don't think homebrew-cpp-autobrew is used for anything so removing that should be fine.
IIUC the version manipulation in utils-prepare.sh is necessary due to the possibility that the R package adds a 4th version component for R-only fixes during CRAN submission e.g. 6.0.0.2.
Thanks for sharing about the context. It seems that we can't run CI jobs for autobrew because we don't have CI environment for old macOS. So can we remove CI jobs for autobrew?
IIUC the version manipulation in
utils-prepare.shis necessary due to the possibility that the R package adds a 4th version component for R-only fixes during CRAN submission e.g. 6.0.0.2.
The removed codes in utils-prepare.sh are only for autobrew's CI jobs. It's not related to release process. If we remove autobrew's CI jobs, we can remove them safely.
@github-actions crossbow submit wheel-macos-*
Revision: a011390d6bd671a461a50ae23f65eed1b4189d3c
Submitted crossbow builds: ursacomputing/crossbow @ actions-3dbd7f7c62
we don't have CI environment for old macOS
We are working on 10.13 self-hosted runners specifically for the R auto-brew builds atm. As CRAN builds on 10.13 and will block our submission if we don't pass on it, we really want to make sure it works to avoid lengthy discussions with CRAN. So please do not remove those builds.
What are the issues you had with the self-hosted mac runner? We will likely keep it deactivated as we have the new, extended capacity in crossbow that should take care of our mac build needs. (ex. autobrew :) )
We are working on 10.13 self-hosted runners specifically for the R auto-brew builds atm.
Wow! I didn't know it! What runs-on should we use for the 10.13 self-hosted runners?
Due to the 10.13 being eol homebrew does not work so we won't be able to use the normal R install actions but rather will have to customize the templates a bit. We will likely have separate tags for r-oldrel and r-release version (so maybe macos-13-release ?).
For now I would think it best/easiest to comment these tasks out from tasks.yml and update the workflows & tags in a follow up.
There is also https://issues.apache.org/jira/browse/ARROW-12590 which probably needs to happen now as the old formula is what is causing the issue on macos >= 11. I'll check it out
We could than add a param/matrix for the runner so that we can run this for both 10.13 and >=11
Are the 3.10 wheel build failures new?
The wheel failure is a pip installation failure of crc32c, which it now tries to install from source instead of using a wheel
The wheel failure is a pip installation failure of crc32c, which it now tries to install from source instead of using a wheel
Which is weird, because binary wheels are provided. Perhaps need to update pip to the latest version first?
It looks like the azure builds will also be affected https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=30742&view=logs&j=cf796865-97b7-5cd1-be8e-6e00ce4fd8cf
@github-actions crossbow submit wheel-macos-*
@github-actions crossbow submit conda-osx-*
Revision: 288fba4485d8efdccf7dd360cf775c1c79eb7f91
Submitted crossbow builds: ursacomputing/crossbow @ actions-389e663b84
Revision: 288fba4485d8efdccf7dd360cf775c1c79eb7f91
Submitted crossbow builds: ursacomputing/crossbow @ actions-85172d3456
@github-actions crossbow submit -g nightly-tests -g nightly-packaging -g nightly-release
Revision: 05c717d36bd71675018cacafede39908458ecc41
Submitted crossbow builds: ursacomputing/crossbow @ actions-7896db46bb
@github-actions crossbow submit verify-rc-source--macos-
Revision: 05c717d36bd71675018cacafede39908458ecc41
Submitted crossbow builds: ursacomputing/crossbow @ actions-8e344ac9dc
@github-actions crossbow submit verify-rc-source--macos-