ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes

[paleolimbot]

trafficstars

In ARROW-15857 (#12734) we fixed the nightly failures on rhub/fedora-clang-devel by a kludge modifying the default makefile, but also upstreamed the fixes (https://github.com/rstudio/sass/pull/104 and https://github.com/r-hub/rhub-linux-builders/pull/60). These upstreams are now both released, so we can remove the kludge from modification of the docker image.

[paleolimbot]

@github-actions crossbow submit test-r-linux-as-cran

[github-actions[bot]]

Revision: fa02aa5369bda7f0ac41b8644743ab9e7ab215d5

Submitted crossbow builds: ursacomputing/crossbow @ actions-1827

Task	Status
test-r-linux-as-cran

[paleolimbot]

(This is failing because the latest release of the 'sass' package didn't actually contain the upstreamed fix despite the NEWS bullet indicating that it was, so we have to wait for 0.4.2 to be released: https://github.com/rstudio/sass/releases).

[paleolimbot]

As per ARROW-16310, we also need to make sure that test-fedora-r-clang-sanitizer passes since the current Makefile modifications might be affecting the install of tzdb.

[pitrou]

@paleolimbot What's the status on this? Should this PR be kept open?

[paleolimbot]

@github-actions crossbow submit test-r-linux-as-cran

[github-actions[bot]]

Revision: d6cfe592639c42bc5d1ce8be843a763beb539079

Submitted crossbow builds: ursacomputing/crossbow @ actions-32da4d031b

Task	Status
test-r-linux-as-cran

[paleolimbot]

This looks like it works...I was waiting on a release of the 'sass' package that didn't properly pick up linker flags from the CXXFLAGS environment variable after I'd upstreamed the fix to rhub and the sass package. I don't spend a lot of time in the CI so it should probably have a look from @assignUser before merging.

[paleolimbot]

@github-actions crossbow submit test-r-linux-as-cran

[github-actions[bot]]

Revision: 3c439dedf3a01bdbdf71843695296e5401658465

Submitted crossbow builds: ursacomputing/crossbow @ actions-c95ef40d0f

Task	Status
test-r-linux-as-cran

[paleolimbot]

@github-actions crossbow submit test-r-linux-as-cran

[github-actions[bot]]

Revision: 45b7556d4ba10ed68685b5859d9fac193a3a9864

Submitted crossbow builds: ursacomputing/crossbow @ actions-c9fd68f714

Task	Status
test-r-linux-as-cran

[assignUser]

@github-actions crossbow submit test-r-linux-as-cran

[github-actions[bot]]

Revision: 45b7556d4ba10ed68685b5859d9fac193a3a9864

Submitted crossbow builds: ursacomputing/crossbow @ actions-7509e9f2b3

Task	Status
test-r-linux-as-cran

[assignUser]

@paleolimbot I re-ran the failed job with arrow_r_dev but it worked so I started another run which also passed, maybe a change in the docker image or some other flakiness?

[paleolimbot]

I can't personally explain the previous failure (the code chunk I added back in seems pretty well fenced to the one image). Thanks for taking a look! I need to open up the image locally to make sure that gnu extensions are not being loaded with those Makevars (I can't see why they would be with those flags but seeing as the image has one job...)

[paleolimbot]

@github-actions crossbow submit test-r-linux-as-cran

[paleolimbot]

I investigated this, and the rhub image doesn't need anything additional to ensure that libc++ is getting used even with the -std=gnu++XXX flag:

# docker run --rm -it rhub/fedora-clang-devel bash
printf "#include <ciso646>\n#ifdef _LIBCPP_VERSION\n#error Using libc++\n#endif" > test.cpp
/opt/R-devel/bin/R CMD SHLIB test.cpp
# /usr/bin/clang++ -std=gnu++14 -stdlib=libc++ -I"/opt/R-devel/lib64/R/include" -DNDEBUG   -I/usr/local/include    -fpic   -g -O2  -c test.cpp -o test.o
# test.cpp:3:2: error: Using libc++
# #error Using libc++
#  ^
# 1 error generated.
/usr/bin/clang++ -stdlib=libc++ -I/usr/local/include -g -O2 -std=gnu++11 -E test.cpp | head -n 1
# test.cpp:3:2: error: Using libc++
# #error Using libc++
#  ^
# 1 error generated.

[github-actions[bot]]

Revision: 1748b23973ae6a0b4f70443668f5067d2da05b00

Submitted crossbow builds: ursacomputing/crossbow @ actions-d762bd3886

Task	Status
test-r-linux-as-cran

[ursabot]

Benchmark runs are scheduled for baseline = 3c13dc4e54b0c539349610ffd791e5d5cabb40e2 and contender = c90d07f74a2af924bf156391a67914d03a6119c6. c90d07f74a2af924bf156391a67914d03a6119c6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. Conbench compare runs links: [Finished :arrow_down:0.0% :arrow_up:0.0%] ec2-t3-xlarge-us-east-2 [Failed :arrow_down:0.0% :arrow_up:0.0%] test-mac-arm [Failed :arrow_down:0.82% :arrow_up:0.0%] ursa-i9-9960x [Failed :arrow_down:2.78% :arrow_up:0.0%] ursa-thinkcentre-m75q Buildkite builds: [Finished] c90d07f7 ec2-t3-xlarge-us-east-2 [Failed] c90d07f7 test-mac-arm [Failed] c90d07f7 ursa-i9-9960x [Failed] c90d07f7 ursa-thinkcentre-m75q [Finished] 3c13dc4e ec2-t3-xlarge-us-east-2 [Failed] 3c13dc4e test-mac-arm [Failed] 3c13dc4e ursa-i9-9960x [Failed] 3c13dc4e ursa-thinkcentre-m75q Supported benchmarks: ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True test-mac-arm: Supported benchmark langs: C++, Python, R ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java