apisix icon indicating copy to clipboard operation
apisix copied to clipboard

fix(brotli): Preserve `ETag` and `Last-Modified` headers in Brotli-compressed response

Open joshdcu opened this issue 1 month ago • 4 comments

Description

Preserve ETag and Last-Modified headers in Brotli-compressed response.

Which issue(s) this PR fixes:

Fixes #12707

Checklist

  • [x] I have explained the need for this PR and the problem it solves
  • [x] I have explained the changes or the new features added to this PR
  • [ ] I have added tests corresponding to this change
  • [ ] I have updated the documentation to reflect this change
  • [ ] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

joshdcu avatar Oct 28 '25 06:10 joshdcu

Hi @yuweizzz, could you please confirm this change?

Baoyuantop avatar Oct 30 '25 03:10 Baoyuantop

It is ok to preserve those headers, but for the etag header, if it exists, you need to transfer it to weak etag.

and add a test case.

yuweizzz avatar Oct 30 '25 06:10 yuweizzz

It is ok to preserve those headers, but for the etag header, if it exists, you need to transfer it to weak etag.

and add a test case.

Hi @joshdcu, can you make further modifications?

Baoyuantop avatar Nov 03 '25 06:11 Baoyuantop

Yes, will be working on it soon, thanks for the reminder!

joshdcu avatar Nov 03 '25 06:11 joshdcu

Hi @joshdcu, any update?

Baoyuantop avatar Dec 16 '25 08:12 Baoyuantop

Sorry @Baoyuantop! I've been unavailable and haven't made a start yet. I would like to work on this eventually but I'm happy to let someone take this up if they want to.

joshdcu avatar Dec 16 '25 09:12 joshdcu