amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[AMORO-3608] Using rolling batch files cleaner to reduce memory usage

Open xxubai opened this issue 5 months ago • 1 comments

Why are the changes needed?

Subtask of #3608

Brief change log

  • As title

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [x] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

xxubai avatar Jun 19 '25 02:06 xxubai

Codecov Report

:x: Patch coverage is 83.58209% with 11 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 28.34%. Comparing base (7197ec6) to head (34772ea). :warning: Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
.../apache/amoro/server/utils/RollingFileCleaner.java 79.62% 6 Missing and 5 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3630      +/-   ##
============================================
+ Coverage     21.76%   28.34%   +6.57%     
- Complexity     2391     3722    +1331     
============================================
  Files           436      618     +182     
  Lines         40498    49883    +9385     
  Branches       5743     6440     +697     
============================================
+ Hits           8816    14140    +5324     
- Misses        30935    34730    +3795     
- Partials        747     1013     +266     
Flag Coverage Δ
core 28.34% <83.58%> (?)
trino ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Jun 19 '25 03:06 codecov-commenter

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Sep 05 '25 00:09 github-actions[bot]

It seems there are some CI issues that need to be fixed. @xxubai

zhoujinsong avatar Sep 15 '25 09:09 zhoujinsong