amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[AMORO-3445] Clean outdated data

Open ihadoop opened this issue 7 months ago • 3 comments

Why are the changes needed?

Close #3445 .

Brief change log

  • set a timer to delete history data for all records in database

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

ihadoop avatar Apr 28 '25 14:04 ihadoop

Screenshot 2025-04-30 at 18 19 36 @zhoujinsong zhou code coverage checking is error, do you know anyone who can fix it

ihadoop avatar Apr 30 '25 10:04 ihadoop

Codecov Report

Attention: Patch coverage is 52.77778% with 17 lines in your changes missing coverage. Please review.

Project coverage is 28.28%. Comparing base (d7d6534) to head (dc5b46a). Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...che/amoro/server/table/timer/TimerTaskManager.java 61.53% 9 Missing and 1 partial :warning:
...ver/table/executor/OptimizingExpiringExecutor.java 14.28% 6 Missing :warning:
...org/apache/amoro/server/AmoroServiceContainer.java 66.66% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3537      +/-   ##
============================================
+ Coverage     21.76%   28.28%   +6.51%     
- Complexity     2391     3698    +1307     
============================================
  Files           431      611     +180     
  Lines         40498    49623    +9125     
  Branches       5744     6423     +679     
============================================
+ Hits           8816    14034    +5218     
- Misses        30935    34580    +3645     
- Partials        747     1009     +262     
Flag Coverage Δ
core 28.28% <52.77%> (?)
trino ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Apr 30 '25 13:04 codecov-commenter

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Jun 27 '25 00:06 github-actions[bot]

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Jul 04 '25 00:07 github-actions[bot]