amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[Feature]: Support to stop/restart the optimizers when stop/restart the ams server

Open klion26 opened this issue 1 year ago • 7 comments

Description

Currently, the optimizers would not be stopped/restarted when the ams server stopped/restarted, but these are some scenarios which the optimizers need to be stopped/restarted such as we make an incompatible upgrade, or there are some critical bugs in the old version.

Use case/motivation

No response

Describe the solution

  1. stop the optimizers when the ams server stopped
  2. restart(stop + start with the new version) when restart the ams server

Subtasks

No response

Related issues

No response

Are you willing to submit a PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

klion26 avatar Nov 12 '24 02:11 klion26

If anyone else is interested, please feel free to contribute. I will contribute to this if I find time(it's a little busy currently).

klion26 avatar Nov 12 '24 02:11 klion26

cool,can i try

ihadoop avatar Dec 16 '24 11:12 ihadoop

i have question about stoping the optimizers when the ams server stopped. As i know,ams has ha, i assume when all ams server stopped then we can stop optimizers.

ihadoop avatar Dec 16 '24 12:12 ihadoop

cool,can i try

@ihadoop Sure, please go ahead.

i have question about stoping the optimizers when the ams server stopped. As i know,ams has ha, i assume when all ams server stopped then we can stop optimizers.

from my side, the stop is here when the user calls ./bin/ams.sh stop, we can(with option) stop the optimizers also.

If you can share how to implement it before the code, it's better. thanks.

klion26 avatar Dec 17 '24 01:12 klion26

want to add stop-all.sh & start-all.sh

ihadoop avatar Dec 19 '24 14:12 ihadoop

@klion26 could you help to check? if match you design, i will do more testing

ihadoop avatar Dec 19 '24 15:12 ihadoop

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

github-actions[bot] avatar Jun 18 '25 00:06 github-actions[bot]

This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'

github-actions[bot] avatar Jul 02 '25 00:07 github-actions[bot]