amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[AMORO-1766] Implement table self-optimizing metric collection

Open huyuanfeng2018 opened this issue 2 years ago • 3 comments

Why are the changes needed?

Close #1766

Brief change log

Add self-optimizing-metric indicator collection logic

How was this patch tested?

  • [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

huyuanfeng2018 avatar Sep 04 '23 11:09 huyuanfeng2018

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (d48c0e0) 52.94% compared to head (fe40238) 52.75%. Report is 8 commits behind head on master.

Files Patch % Lines
...metrics/SelfOptimizingStatusDurationMsContent.java 60.71% 11 Missing :warning:
...rver/metrics/SelfOptimizingTotalCostMsContent.java 52.63% 9 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1913      +/-   ##
============================================
- Coverage     52.94%   52.75%   -0.20%     
- Complexity     3612     4235     +623     
============================================
  Files           465      513      +48     
  Lines         24502    29412    +4910     
  Branches       2340     2853     +513     
============================================
+ Hits          12973    15515    +2542     
- Misses        10510    12653    +2143     
- Partials       1019     1244     +225     
Flag Coverage Δ
core 53.10% <76.19%> (+0.16%) :arrow_up:
trino 50.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 04 '23 11:09 codecov[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


huyuanfeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 22 '23 08:11 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


huyuanfeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 22 '23 08:11 CLAassistant

I think this PR could be closed due to https://github.com/apache/amoro/pull/2674 is merged.

@zhoujinsong @huyuanfeng2018

baiyangtx avatar Apr 27 '24 05:04 baiyangtx

Closed due to https://github.com/apache/amoro/pull/2674

baiyangtx avatar May 09 '24 01:05 baiyangtx