airflow icon indicating copy to clipboard operation
airflow copied to clipboard

AIP-59 Performance testing framework

Open bjankie1 opened this issue 1 year ago • 5 comments


Initial version of performance testing framework - AIP-59.

Note: PR created for early review, testing in progress - not ready for merge.

^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

bjankie1 avatar Aug 07 '24 18:08 bjankie1

Is there any chance you could split up this PR in multiple PRs? 15k lines of code is really hard to review :)

vincbeck avatar Aug 07 '24 19:08 vincbeck

Agree. Would be nice to separate out piece by piece and review them in smaller increments. Generally review time is at least O(n^2)

potiuk avatar Aug 12 '24 00:08 potiuk

I also suggest breaking this down into separate PRs. Also, can we have some documentation in the README file for installation of airflow_gepard

vatsrahul1001 avatar Aug 13 '24 06:08 vatsrahul1001

I will make an attempt to divide the code into several PRs.

  1. Framework for building performance DAGs
  2. Framework for collecting instance metrics in kubernetes.
  3. Framework for collecting instance metrics in Cloud Composer.
  4. Glue code - performance tests execution

bjankie1 avatar Aug 18 '24 20:08 bjankie1

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 18 '24 00:10 github-actions[bot]

Hello, any update about this ?

mathiaHT avatar Jan 06 '25 09:01 mathiaHT

Any update?

Asquator avatar Apr 26 '25 12:04 Asquator