airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Remove mysql/postgres from extras before determining the installation_command_flags

Open macchiang opened this issue 1 year ago • 2 comments

  • Fix the build error with the build-args INSTALL_MYSQL_CLIENT=false or INSTALL_POSTGRES_CLIENT=false

^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

macchiang avatar May 14 '24 09:05 macchiang

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar May 14 '24 09:05 boring-cyborg[bot]

Nice! Thanks!

potiuk avatar May 14 '24 09:05 potiuk

SOme static check failure. The other issue with tests is being fixed (broken main)

potiuk avatar May 14 '24 10:05 potiuk

@potiuk @dirrao All fixed.

macchiang avatar May 15 '24 08:05 macchiang

Still some static-checks failing (I recommend installing and running pre-commit locally, it will fix things for you.

potiuk avatar May 15 '24 09:05 potiuk

@potiuk All good now. 🚀

macchiang avatar May 15 '24 13:05 macchiang

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

boring-cyborg[bot] avatar May 15 '24 18:05 boring-cyborg[bot]