anytype-ts
anytype-ts copied to clipboard
anyproto
Replace width to translate
- [x] I understand that contributing to this repository will require me to agree with the CLA
Description
Using translate to replace the original left and width animations reduces the performance cost of page reflows.
The modified code should allow for the removal of some width-related sections, but I'm not certain which ones are essential.
What type of PR is this? (check all applicable)
- [ ] 🍕 Feature
- [ ] 🐛 Bug Fix
- [ ] 📝 Documentation Update
- [x] 🎨 Style
- [ ] 🧑💻 Code Refactor
- [x] 🔥 Performance Improvements
- [ ] ✅ Test
- [ ] 🤖 Build
- [ ] 🔁 CI
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Spaces & widgets
Only widgets
Added tests?
- [ ] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [x] 🙋 no, because I need help
Added to documentation?
- [ ] 📜 README.md
- [ ] 📓 tech-docs
- [x] 🙅 no documentation needed
[optional] Are there any post-deployment tasks we need to perform?
I think I can't approve this unfortunately as this was a design decision, but I will ask.
I think I can't approve this unfortunately as this was a design decision, but I will ask.
Design decision? Can you elaborate a little?
The main problem with changing width animation to translate is that right now there is common code that controls the resize of the sidebar, page resize and elements animation, splitting this code into show/hide and resize may be done but it will complicate things much more and we do not have time at the moment for this change. Maybe it will be reviewed one more time with the introduction of the right panel. By design decision I meant that we have discussed it with designers.