orval icon indicating copy to clipboard operation
orval copied to clipboard

fix: Angular client props nullability

Open jonimake opened this issue 6 months ago • 2 comments

Status

READY

Description

Handle angular http client parameter nullability in a more robust way that doesn't force all schema properties to be non nullable. Adds a new utility type DeepNonNullable that is used to wrap all angular client query param props instead of making all scalars non-nullable in angular configuration.

Fix #2092 for reference

Todos

  • [x] Tests
  • [x] Documentation
  • [ ] Changelog Entry (unreleased)

Steps to Test or Reproduce

You can either run the tests for the project (there is a new test case for the happy path for angular in propts.test.ts) or you can generate the sample angular client. The http client query params should be wrapped with DeepNonNullable type to enforce no nulls can be set there.

jonimake avatar May 20 '25 19:05 jonimake

Running the build now!

melloware avatar May 20 '25 20:05 melloware

@jonimake looks like tests are failing?

melloware avatar May 21 '25 11:05 melloware

any updates? it's look like a critical bug with strict types enabled in project

niklissad avatar Jun 24 '25 15:06 niklissad

this has been moved here can you guys respond in that PR please: https://github.com/orval-labs/orval/pull/2244

melloware avatar Jul 27 '25 15:07 melloware