orval
orval copied to clipboard
fix: Angular client props nullability
Status
READY
Description
Handle angular http client parameter nullability in a more robust way that doesn't force all schema properties to be non nullable. Adds a new utility type DeepNonNullable that is used to wrap all angular client query param props instead of making all scalars non-nullable in angular configuration.
Fix #2092 for reference
Todos
- [x] Tests
- [x] Documentation
- [ ] Changelog Entry (unreleased)
Steps to Test or Reproduce
You can either run the tests for the project (there is a new test case for the happy path for angular in propts.test.ts) or you can generate the sample angular client. The http client query params should be wrapped with DeepNonNullable type to enforce no nulls can be set there.
Running the build now!
@jonimake looks like tests are failing?
any updates? it's look like a critical bug with strict types enabled in project
this has been moved here can you guys respond in that PR please: https://github.com/orval-labs/orval/pull/2244