orval icon indicating copy to clipboard operation
orval copied to clipboard

Published 20 hours ago • verified publisher icon anymaniax

feat(query): support custom-fetch-hook

Open izumin5210 opened this issue 1 year ago • 4 comments

Status

READY

Description

Currently, Orval generates broken code when mutator is custom fetch client hook.

Todos

  • [x] Tests
  • [ ] Documentation
  • [ ] Changelog Entry (unreleased)

Steps to Test or Reproduce

You can check by using sample app.

izumin5210 avatar Sep 18 '24 07:09 izumin5210

Looks like build is failing?

melloware avatar Sep 18 '24 11:09 melloware

Thank you for nice enhance ! I don't want to include the hooks concerns in the fetch package alone, so give me some time to think about how to get around that.

soartec-lab avatar Sep 18 '24 12:09 soartec-lab

I've thought about this, and I'd like to have no query concerns in the fetch package. But that would require me to do more refactoring, so I'll make another one after this PR is merged.

soartec-lab avatar Sep 22 '24 02:09 soartec-lab

@izumin5210 Could you fix the failing tests?

soartec-lab avatar Sep 22 '24 02:09 soartec-lab

@soartec-lab you might have to just take this PR over

melloware avatar Mar 13 '25 01:03 melloware

Yes, there is a conflict, so I will close it for now. If a new issue arises, I will revisit this.

soartec-lab avatar Mar 13 '25 09:03 soartec-lab