orval icon indicating copy to clipboard operation
orval copied to clipboard

Fix/post abort signal param

Open wengergruppe opened this issue 1 year ago • 9 comments

Status

Fix #1434 Fix #1447

READY/WIP/HOLD

Description

A few sentences describing the overall goals of the pull request's commits.

Related PRs

List related PRs against other branches:

branch PR
other_pr_production link
other_pr_master link

Todos

  • [ ] Tests
  • [ ] Documentation
  • [ ] Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> grunt jasmine

wengergruppe avatar Sep 10 '24 20:09 wengergruppe

I assume this is for #1434 and #1447 ???

melloware avatar Sep 10 '24 20:09 melloware

please run npm run format

melloware avatar Sep 10 '24 20:09 melloware

Yes, this PR is for both issues> I assume this is for #1434 and #1447 ???

wengergruppe avatar Sep 11 '24 08:09 wengergruppe

Sorry, perhaps, i didn't run husky hooks. I will check. Can you explain me, how do you test, that contract is corretly generated and PR will work? > please run npm run format

wengergruppe avatar Sep 11 '24 08:09 wengergruppe

hmmm you should just be able to run the full build locally which checks format, tests, lint?

melloware avatar Sep 11 '24 11:09 melloware

@wengergruppe were you going to fix this so it can be merged?

melloware avatar Sep 16 '24 13:09 melloware

Yes. Today i am going to commit fixes.

wengergruppe avatar Sep 16 '24 13:09 wengergruppe

Ping

melloware avatar Oct 01 '24 00:10 melloware

@wengergruppe where are you at with this?

melloware avatar Oct 12 '24 12:10 melloware

@wengergruppe are you fixing the formatting?, I can help to fix it if you can provide write access

gsaandy avatar Nov 03 '24 09:11 gsaandy

@gsaandy if you want to make a new PR with these changes that would be great. Then we can close this one and merge yours

melloware avatar Nov 03 '24 11:11 melloware

@gsaandy if you want to make a new PR with these changes that would be great. Then we can close this one and merge yours

@melloware here is the new PR https://github.com/orval-labs/orval/pull/1688. Note: I only fixed the formatting, the existing tests and build looks good.

gsaandy avatar Nov 03 '24 14:11 gsaandy