orval
orval copied to clipboard
Fix/post abort signal param
Status
Fix #1434 Fix #1447
READY/WIP/HOLD
Description
A few sentences describing the overall goals of the pull request's commits.
Related PRs
List related PRs against other branches:
| branch | PR |
|---|---|
| other_pr_production | link |
| other_pr_master | link |
Todos
- [ ] Tests
- [ ] Documentation
- [ ] Changelog Entry (unreleased)
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
> git pull --prune
> git checkout <branch>
> grunt jasmine
I assume this is for #1434 and #1447 ???
please run npm run format
Yes, this PR is for both issues> I assume this is for #1434 and #1447 ???
Sorry, perhaps, i didn't run husky hooks. I will check.
Can you explain me, how do you test, that contract is corretly generated and PR will work? > please run npm run format
hmmm you should just be able to run the full build locally which checks format, tests, lint?
@wengergruppe were you going to fix this so it can be merged?
Yes. Today i am going to commit fixes.
Ping
@wengergruppe where are you at with this?
@wengergruppe are you fixing the formatting?, I can help to fix it if you can provide write access
@gsaandy if you want to make a new PR with these changes that would be great. Then we can close this one and merge yours
@gsaandy if you want to make a new PR with these changes that would be great. Then we can close this one and merge yours
@melloware here is the new PR https://github.com/orval-labs/orval/pull/1688. Note: I only fixed the formatting, the existing tests and build looks good.